diff options
author | Chiachang Wang <chiachangwang@google.com> | 2019-04-11 21:24:28 +0800 |
---|---|---|
committer | Chiachang Wang <chiachangwang@google.com> | 2019-04-11 21:24:28 +0800 |
commit | 53817ca825184966e4e84ead4b64e677c39d18a4 (patch) | |
tree | 5ff6c7b6267744225970ee0c1545c8ba9dfd5e91 /src/android/net/metrics/DataStallStatsUtils.java | |
parent | 1b40047789ca45d09401bed2c53e0fce17a1ee91 (diff) |
Migrate NetworkStack metrics off StatsLog.write
Now that the new metrics API can be used, NetworkStack
metrics need to migrate off the legacy StatsLog.write.
Bug: 130323000
Test: Test with ./out/host/linux-x86/bin/statsd_testdrive 121
to ensure log properly
Test: Ensure NetworkStackStatsLog will be generated as expected
Test: atest NetworkStackTest
Change-Id: I8c70503cf1d9f1d06f30a1936d2d88857d0cff53
Diffstat (limited to 'src/android/net/metrics/DataStallStatsUtils.java')
-rw-r--r-- | src/android/net/metrics/DataStallStatsUtils.java | 77 |
1 files changed, 0 insertions, 77 deletions
diff --git a/src/android/net/metrics/DataStallStatsUtils.java b/src/android/net/metrics/DataStallStatsUtils.java deleted file mode 100644 index e23f10f..0000000 --- a/src/android/net/metrics/DataStallStatsUtils.java +++ /dev/null @@ -1,77 +0,0 @@ -/* - * Copyright (C) 2019 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package android.net.metrics; - -import android.annotation.NonNull; -import android.annotation.Nullable; -import android.net.captiveportal.CaptivePortalProbeResult; -import android.util.Log; -import android.util.StatsLog; - -import com.android.internal.util.HexDump; -import com.android.server.connectivity.nano.DataStallEventProto; - -/** - * Collection of utilities for data stall metrics. - * - * To see if the logs are properly sent to statsd, execute following command. - * - * $ adb shell cmd stats print-logs - * $ adb logcat | grep statsd OR $ adb logcat -b stats - * - * @hide - */ -public class DataStallStatsUtils { - private static final String TAG = DataStallStatsUtils.class.getSimpleName(); - private static final int DATA_STALL_EVENT_ID = 121; - private static final boolean DBG = false; - - private static int probeResultToEnum(@Nullable final CaptivePortalProbeResult result) { - if (result == null) return DataStallEventProto.INVALID; - - // TODO: Add partial connectivity support. - if (result.isSuccessful()) { - return DataStallEventProto.VALID; - } else if (result.isPortal()) { - return DataStallEventProto.PORTAL; - } else if (result.isPartialConnectivity()) { - return DataStallEventProto.PARTIAL; - } else { - return DataStallEventProto.INVALID; - } - } - - /** - * Write the metric to {@link StatsLog}. - */ - public static void write(@NonNull final DataStallDetectionStats stats, - @NonNull final CaptivePortalProbeResult result) { - int validationResult = probeResultToEnum(result); - if (DBG) { - Log.d(TAG, "write: " + stats + " with result: " + validationResult - + ", dns: " + HexDump.toHexString(stats.mDns)); - } - // TODO(b/124613085): Update API once the public StatsLog API is ready. - StatsLog.write(DATA_STALL_EVENT_ID, - stats.mEvaluationType, - validationResult, - stats.mNetworkType, - stats.mWifiInfo, - stats.mCellularInfo, - stats.mDns); - } -} |