summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRemi NGUYEN VAN <reminv@google.com>2020-02-07 07:52:36 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2020-02-07 07:52:36 +0000
commitee23002c1f0a547ea46fa399d20caf542e68ab57 (patch)
treed4856f75ccbb78298ff7b246b1bad0d93687b391
parent0b2fd40071a846fb32a9e0d105856e094cf098c1 (diff)
parent954eafa1841682430808b1e0fe2e76554992f7fc (diff)
Merge "Skip getConnectionOwnerUid tests on Q"
-rw-r--r--tests/unit/src/android/net/netlink/InetDiagSocketTest.java8
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/unit/src/android/net/netlink/InetDiagSocketTest.java b/tests/unit/src/android/net/netlink/InetDiagSocketTest.java
index 84c5784..6b5ebdc 100644
--- a/tests/unit/src/android/net/netlink/InetDiagSocketTest.java
+++ b/tests/unit/src/android/net/netlink/InetDiagSocketTest.java
@@ -31,11 +31,13 @@ import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
+import static org.junit.Assume.assumeTrue;
import android.app.Instrumentation;
import android.content.Context;
import android.net.ConnectivityManager;
import android.net.netlink.StructNlMsgHdr;
+import android.os.Build;
import android.os.Process;
import android.system.Os;
@@ -43,6 +45,8 @@ import androidx.test.InstrumentationRegistry;
import androidx.test.filters.SmallTest;
import androidx.test.runner.AndroidJUnit4;
+import com.android.networkstack.apishim.ShimUtils;
+
import libcore.util.HexEncoding;
import org.junit.Before;
@@ -191,6 +195,8 @@ public class InetDiagSocketTest {
@Test
public void testGetConnectionOwnerUid() throws Exception {
+ // Skip the test for API <= Q, as b/141603906 this was only fixed in Q-QPR2
+ assumeTrue(ShimUtils.isReleaseOrDevelopmentApiAbove(Build.VERSION_CODES.Q));
checkGetConnectionOwnerUid("::", null);
checkGetConnectionOwnerUid("::", "::");
checkGetConnectionOwnerUid("0.0.0.0", null);
@@ -204,6 +210,8 @@ public class InetDiagSocketTest {
/* Verify fix for b/141603906 */
@Test
public void testB141603906() throws Exception {
+ // Skip the test for API <= Q, as b/141603906 this was only fixed in Q-QPR2
+ assumeTrue(ShimUtils.isReleaseOrDevelopmentApiAbove(Build.VERSION_CODES.Q));
final InetSocketAddress src = new InetSocketAddress(0);
final InetSocketAddress dst = new InetSocketAddress(0);
final int numThreads = 8;