diff options
author | Myles Watson <mylesgw@google.com> | 2019-06-03 09:06:26 -0700 |
---|---|---|
committer | Myles Watson <mylesgw@google.com> | 2019-06-03 09:15:59 -0700 |
commit | cad11f498aab54948eda14fa134a1dcba9c6acc6 (patch) | |
tree | 3c06b8123efec5175b0cebb804ef51b6656fb88a /system/gd/os/linux_generic/queue_unittest.cc | |
parent | cd2fad660849b59063bb7ad87ddf8dcd3223371b (diff) |
Revert "OS: Construct Handler using Reactor"
Reactors are an implementation-specific detail.
This reverts commit 86d57ec783839f068675114f6772c45f9782fff9.
Test: bluetooth_gd_test
Change-Id: If74a9e0f32671ba96a723e51eee495f2aebf1e7c
Diffstat (limited to 'system/gd/os/linux_generic/queue_unittest.cc')
-rw-r--r-- | system/gd/os/linux_generic/queue_unittest.cc | 41 |
1 files changed, 4 insertions, 37 deletions
diff --git a/system/gd/os/linux_generic/queue_unittest.cc b/system/gd/os/linux_generic/queue_unittest.cc index 9c1852797b..e0cd6e0a17 100644 --- a/system/gd/os/linux_generic/queue_unittest.cc +++ b/system/gd/os/linux_generic/queue_unittest.cc @@ -57,31 +57,13 @@ class QueueTest : public ::testing::Test { Handler* dequeue_handler_; }; -class QueueTestSingleThread : public ::testing::Test { - protected: - void SetUp() override { - reactor_ = new Reactor(); - enqueue_handler_ = new Handler(reactor_); - dequeue_handler_ = new Handler(reactor_); - } - void TearDown() override { - delete enqueue_handler_; - delete dequeue_handler_; - delete reactor_; - enqueue_handler_ = nullptr; - dequeue_handler_ = nullptr; - reactor_ = nullptr; - } - Reactor* reactor_; - Handler* enqueue_handler_; - Handler* dequeue_handler_; -}; - class TestEnqueueEnd { public: explicit TestEnqueueEnd(Queue<std::string>* queue, Handler* handler) : count(0), handler_(handler), queue_(queue), delay_(0) {} + ~TestEnqueueEnd() {} + void RegisterEnqueue(std::unordered_map<int, std::promise<int>>* promise_map) { promise_map_ = promise_map; handler_->Post([this] { queue_->RegisterEnqueue(handler_, [this] { return EnqueueCallbackForTest(); }); }); @@ -138,6 +120,8 @@ class TestDequeueEnd { explicit TestDequeueEnd(Queue<std::string>* queue, Handler* handler, int capacity) : count(0), handler_(handler), queue_(queue), capacity_(capacity), delay_(0) {} + ~TestDequeueEnd() {} + void RegisterDequeue(std::unordered_map<int, std::promise<int>>* promise_map) { promise_map_ = promise_map; handler_->Post([this] { queue_->RegisterDequeue(handler_, [this] { DequeueCallbackForTest(); }); }); @@ -711,23 +695,6 @@ TEST_F(QueueTest, pass_smart_pointer_and_unregister) { }); future.wait(); } - -TEST_F(QueueTestSingleThread, no_unregister_enqueue_death_test) { - Queue<std::string>* queue = new Queue<std::string>(kQueueSizeOne); - - queue->RegisterEnqueue(enqueue_handler_, - []() { return std::make_unique<std::string>("A string to fill the queue"); }); - - EXPECT_DEATH(delete queue, "nqueue"); -} - -TEST_F(QueueTestSingleThread, no_unregister_dequeue_death_test) { - Queue<std::string>* queue = new Queue<std::string>(kQueueSize); - - queue->RegisterDequeue(dequeue_handler_, []() {}); - - EXPECT_DEATH(delete queue, "equeue"); -} } // namespace } // namespace os } // namespace bluetooth |