hap: Refactor service to match the new API

Bug: 150670922
Bug: 216639668
Fixes: 216639668
Tag: #feature
Test: atest BluetoothInstrumentationTests
Sponsor: jpawlowski@

Change-Id: I4b1ecf818a9b9bd75b1d17abeadfcea7c3c2548b

1 files changed, 198 insertions, 378 deletions

diff --git a/framework/java/android/bluetooth/BluetoothHapClient.java b/framework/java/android/bluetooth/BluetoothHapClient.java
index 2b245bcb41..e28bb50d66 100644
--- a/framework/java/android/bluetooth/BluetoothHapClient.java
+++ b/framework/java/android/bluetooth/BluetoothHapClient.java
@@ -60,6 +60,8 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
 
     private CloseGuard mCloseGuard;
 
+    BluetoothHapClientCallbackDelegate mCallbackDelegate;
+
     /**
      * This class provides callbacks mechanism for the BluetoothHapClient profile.
      *
@@ -83,17 +85,6 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
         })
         @interface Status {}
 
-        /** @hide */
-        @Retention(RetentionPolicy.SOURCE)
-        @IntDef(value = {
-                PRESET_INFO_REASON_ALL_PRESET_INFO,
-                PRESET_INFO_REASON_PRESET_INFO_UPDATE,
-                PRESET_INFO_REASON_PRESET_DELETED,
-                PRESET_INFO_REASON_PRESET_AVAILABILITY_CHANGED,
-                PRESET_INFO_REASON_PRESET_INFO_REQUEST_RESPONSE,
-        })
-        @interface PresetInfoReason {}
-
         /**
          * Invoked to inform about HA device's currently active preset.
          *
@@ -180,6 +171,55 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
         void onSetPresetNameForGroupFailed(int hapGroupId, @Status int status);
     }
 
+    private static class BluetoothHapClientCallbackDelegate
+            extends IBluetoothHapClientCallback.Stub {
+        final Callback mCallback;
+        final Executor mExecutor;
+
+        BluetoothHapClientCallbackDelegate(Executor executor, Callback callback) {
+            mExecutor = executor;
+            mCallback = callback;
+        }
+
+        @Override
+        public void onActivePresetChanged(@NonNull BluetoothDevice device, int presetIndex) {
+            mExecutor.execute(() -> mCallback.onActivePresetChanged(device, presetIndex));
+        }
+
+        @Override
+        public void onSelectActivePresetFailed(@NonNull BluetoothDevice device, int status) {
+            mExecutor.execute(() -> mCallback.onSelectActivePresetFailed(device, status));
+        }
+
+        @Override
+        public void onSelectActivePresetForGroupFailed(int hapGroupId, int statusCode) {
+            mExecutor.execute(
+                    () -> mCallback.onSelectActivePresetForGroupFailed(hapGroupId, statusCode));
+        }
+
+        @Override
+        public void onPresetInfoChanged(@NonNull BluetoothDevice device,
+                @NonNull List<BluetoothHapPresetInfo> presetInfoList, int statusCode) {
+            mExecutor.execute(
+                    () -> mCallback.onPresetInfoChanged(device, presetInfoList, statusCode));
+        }
+
+        @Override
+        public void onHapFeaturesAvailable(@NonNull BluetoothDevice device, int hapFeatures) {
+            mExecutor.execute(() -> mCallback.onHapFeaturesAvailable(device, hapFeatures));
+        }
+
+        @Override
+        public void onSetPresetNameFailed(@NonNull BluetoothDevice device, int status) {
+            mExecutor.execute(() -> mCallback.onSetPresetNameFailed(device, status));
+        }
+
+        @Override
+        public void onSetPresetNameForGroupFailed(int hapGroupId, int status) {
+            mExecutor.execute(() -> mCallback.onSetPresetNameForGroupFailed(hapGroupId, status));
+        }
+    };
+
     /**
      * Intent used to broadcast the change in connection state of the Hearing Access Profile Client
      * service. Please note that in the binaural case, there will be two different LE devices for
@@ -229,235 +269,12 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
             "android.bluetooth.action.HAP_DEVICE_AVAILABLE";
 
     /**
-     * Intent used to broadcast HA device's feature set.
-     *
-     * <p>This intent will have 2 extras:
-     * <ul>
-     * <li> {@link BluetoothDevice#EXTRA_DEVICE} - The remote device. </li>
-     * <li> {@link #EXTRA_HAP_FEATURES}- The feature set integer with these possible bit numbers
-     * set: {@link #FEATURE_BIT_NUM_TYPE_MONAURAL}, {@link #FEATURE_BIT_NUM_TYPE_BANDED},
-     * {@link #FEATURE_BIT_NUM_SYNCHRONIZATED_PRESETS},
-     * {@link #FEATURE_BIT_NUM_INDEPENDENT_PRESETS}, {@link #FEATURE_BIT_NUM_DYNAMIC_PRESETS},
-     * {@link #FEATURE_BIT_NUM_WRITABLE_PRESETS}.</li>
-     * </ul>
-     *
-     * @hide
-     */
-    @RequiresPermission(allOf = {
-            android.Manifest.permission.BLUETOOTH_CONNECT,
-            android.Manifest.permission.BLUETOOTH_PRIVILEGED,
-    })
-    @SdkConstant(SdkConstant.SdkConstantType.BROADCAST_INTENT_ACTION)
-    public static final String ACTION_HAP_ON_DEVICE_FEATURES =
-            "android.bluetooth.action.HAP_ON_DEVICE_FEATURES";
-
-    /**
-     * Intent used to broadcast the change of a HA device's active preset.
-     *
-     * <p>This intent will have 2 extras:
-     * <ul>
-     * <li> {@link BluetoothDevice#EXTRA_DEVICE} - The remote device. </li>
-     * <li> {@link #EXTRA_HAP_PRESET_INDEX}- The currently active preset.</li>
-     * </ul>
-     *
-     * @hide
-     */
-    @RequiresPermission(allOf = {
-            android.Manifest.permission.BLUETOOTH_CONNECT,
-            android.Manifest.permission.BLUETOOTH_PRIVILEGED,
-    })
-    @SdkConstant(SdkConstant.SdkConstantType.BROADCAST_INTENT_ACTION)
-    public static final String ACTION_HAP_ON_ACTIVE_PRESET =
-            "android.bluetooth.action.HAP_ON_ACTIVE_PRESET";
-
-    /**
-     * Intent used to broadcast the result of a failed preset change attempt.
-     *
-     * <p>This intent will have 2 extras:
-     * <ul>
-     * <li> {@link BluetoothDevice#EXTRA_DEVICE} - The remote device. </li>
-     * <li> {@link #EXTRA_HAP_STATUS_CODE}- Failure reason.</li>
-     * </ul>
-     *
-     * <p>{@link #EXTRA_HAP_STATUS_CODE} can be any of {@link #STATUS_INVALID_PRESET_INDEX},
-     * {@link #STATUS_OPERATION_NOT_POSSIBLE},{@link #STATUS_OPERATION_NOT_SUPPORTED}.
-     *
-     * @hide
-     */
-    @RequiresPermission(allOf = {
-            android.Manifest.permission.BLUETOOTH_CONNECT,
-            android.Manifest.permission.BLUETOOTH_PRIVILEGED,
-    })
-    @SdkConstant(SdkConstant.SdkConstantType.BROADCAST_INTENT_ACTION)
-    public static final String ACTION_HAP_ON_ACTIVE_PRESET_SELECT_ERROR =
-            "android.bluetooth.action.HAP_ON_ACTIVE_PRESET_SELECT_ERROR";
-
-    /**
-     * Intent used to broadcast preset name change.
-     *
-     * <p>This intent will have 4 extras:
-     * <ul>
-     * <li> {@link BluetoothDevice#EXTRA_DEVICE} - The remote device. </li>
-     * <li> {@link #EXTRA_HAP_PRESET_INFO}- List of preset informations </li>
-     * <li> {@link #EXTRA_HAP_PRESET_INFO_REASON}- Why this preset info notification was sent </li>
-     * notifications or the user should expect more to come. </li>
-     * </ul>
-     *
-     * @hide
-     */
-    @RequiresPermission(allOf = {
-            android.Manifest.permission.BLUETOOTH_CONNECT,
-            android.Manifest.permission.BLUETOOTH_PRIVILEGED,
-    })
-    @SdkConstant(SdkConstant.SdkConstantType.BROADCAST_INTENT_ACTION)
-    public static final String ACTION_HAP_ON_PRESET_INFO =
-            "android.bluetooth.action.HAP_ON_PRESET_INFO";
-
-    /**
-     * Intent used to broadcast result of a failed rename attempt.
-     *
-     * <p>This intent will have 3 extras:
-     * <ul>
-     * <li> {@link BluetoothDevice#EXTRA_DEVICE} - The remote device. </li>
-     * <li> {@link #EXTRA_HAP_PRESET_INDEX}- The currently active preset.</li>
-     * <li> {@link #EXTRA_HAP_STATUS_CODE}- Failure reason code.</li>
-     * </ul>
-     *
-     * <p>{@link #EXTRA_HAP_STATUS_CODE} can be any of {@link #STATUS_SET_NAME_NOT_ALLOWED},
-     * {@link #STATUS_INVALID_PRESET_INDEX}, {@link #STATUS_INVALID_PRESET_NAME_LENGTH}.
-     *
-     * @hide
-     */
-    @RequiresPermission(allOf = {
-            android.Manifest.permission.BLUETOOTH_CONNECT,
-            android.Manifest.permission.BLUETOOTH_PRIVILEGED,
-    })
-    @SdkConstant(SdkConstant.SdkConstantType.BROADCAST_INTENT_ACTION)
-    public static final String ACTION_HAP_ON_PRESET_NAME_SET_ERROR =
-            "android.bluetooth.action.HAP_ON_PRESET_NAME_SET_ERROR";
-
-    /**
-     * Intent used to broadcast the result of a failed name get attempt.
-     *
-     * <p>This intent will have 3 extras:
-     * <ul>
-     * <li> {@link BluetoothDevice#EXTRA_DEVICE} - The remote device. </li>
-     * <li> {@link #EXTRA_HAP_PRESET_INDEX}- The currently active preset.</li>
-     * <li> {@link #EXTRA_HAP_STATUS_CODE}- Failure reason code.</li>
-     * </ul>
-     *
-     * <p>{@link #EXTRA_HAP_STATUS_CODE} can be any of {@link #STATUS_INVALID_PRESET_INDEX},
-     * {@link #STATUS_OPERATION_NOT_POSSIBLE}.
-     *
-     * @hide
-     */
-    @RequiresPermission(allOf = {
-            android.Manifest.permission.BLUETOOTH_CONNECT,
-            android.Manifest.permission.BLUETOOTH_PRIVILEGED,
-    })
-    @SdkConstant(SdkConstant.SdkConstantType.BROADCAST_INTENT_ACTION)
-    public static final String ACTION_HAP_ON_PRESET_INFO_GET_ERROR =
-            "android.bluetooth.action.HAP_ON_PRESET_INFO_GET_ERROR";
-
-    /**
      * Contains a list of all available presets
      * @hide
      */
     public static final String EXTRA_HAP_FEATURES = "android.bluetooth.extra.HAP_FEATURES";
 
     /**
-     * Contains a preset identifier
-     * @hide
-     */
-    public static final String EXTRA_HAP_PRESET_INDEX = "android.bluetooth.extra.HAP_PRESET_INDEX";
-
-    /**
-     * Used to report failure reasons.
-     * @hide
-     */
-    public static final String EXTRA_HAP_STATUS_CODE = "android.bluetooth.extra.HAP_STATUS_CODE";
-
-    /**
-     * Used by group events.
-     * @hide
-     */
-    public static final String EXTRA_HAP_GROUP_ID = "android.bluetooth.extra.HAP_GROUP_ID";
-
-    /**
-     * Preset Info reason.
-     * Possible values:
-     *  {@link #PRESET_INFO_REASON_ALL_PRESET_INFO} or
-     *  {@link #PRESET_INFO_REASON_PRESET_INFO_UPDATE} or
-     *  {@link #PRESET_INFO_REASON_PRESET_DELETED} or
-     *  {@link #PRESET_INFO_REASON_PRESET_AVAILABILITY_CHANGED} or
-     *  {@link #PRESET_INFO_REASON_PRESET_INFO_REQUEST_RESPONSE}
-     * @hide
-     */
-    public static final String EXTRA_HAP_PRESET_INFO_REASON =
-            "android.bluetooth.extra.HAP_PRESET_INFO_REASON";
-
-    /**
-     * Preset Info.
-     * @hide
-     */
-    public static final String EXTRA_HAP_PRESET_INFO = "android.bluetooth.extra.HAP_PRESET_INFO";
-
-    /**
-     * Preset name change failure due to preset being read-only.
-     * @hide
-     */
-    public static final int STATUS_SET_NAME_NOT_ALLOWED =
-            IBluetoothHapClient.STATUS_SET_NAME_NOT_ALLOWED;
-
-    /**
-     * Means that the requested operation is not supported by the HA device.
-     *
-     * <p> It could mean that the requested name change is not supported on
-     * a given preset or the device does not support presets at all.
-     * @hide
-     */
-    public static final int STATUS_OPERATION_NOT_SUPPORTED =
-            IBluetoothHapClient.STATUS_OPERATION_NOT_SUPPORTED;
-
-    /**
-     * Usually means a temporary denial of certain operation. Peer device may report this
-     * status due to various implementation specific reasons. It's different than
-     * the {@link #STATUS_OPERATION_NOT_SUPPORTED} which represents more of a
-     * permanent inability to perform some of the operations.
-     * @hide
-     */
-    public static final int STATUS_OPERATION_NOT_POSSIBLE =
-            IBluetoothHapClient.STATUS_OPERATION_NOT_POSSIBLE;
-
-    /**
-     * Used when preset name change failed due to the passed name parameter being to long.
-     * @hide
-     */
-    public static final int STATUS_INVALID_PRESET_NAME_LENGTH =
-            IBluetoothHapClient.STATUS_INVALID_PRESET_NAME_LENGTH;
-
-    /**
-     * Group operations are not supported.
-     * @hide
-     */
-    public static final int STATUS_GROUP_OPERATION_NOT_SUPPORTED =
-            IBluetoothHapClient.STATUS_GROUP_OPERATION_NOT_SUPPORTED;
-
-    /**
-     * Procedure is already in progress.
-     * @hide
-     */
-    public static final int STATUS_PROCEDURE_ALREADY_IN_PROGRESS =
-            IBluetoothHapClient.STATUS_PROCEDURE_ALREADY_IN_PROGRESS;
-
-    /**
-     * Invalid preset index input parameter used in one of the API calls.
-     * @hide
-     */
-    public static final int STATUS_INVALID_PRESET_INDEX =
-            IBluetoothHapClient.STATUS_INVALID_PRESET_INDEX;
-
-    /**
      * Represets an invalid index value. This is usually value returned in a currently
      * active preset request for a device which is not connected. This value shouldn't be used
      * in the API calls.
@@ -507,48 +324,6 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     public static final int FEATURE_BIT_NUM_WRITABLE_PRESETS =
             IBluetoothHapClient.FEATURE_BIT_NUM_WRITABLE_PRESETS;
 
-    /**
-     * Preset Info notification reason.
-     * @hide
-     */
-    public static final int PRESET_INFO_REASON_ALL_PRESET_INFO =
-            IBluetoothHapClient.PRESET_INFO_REASON_ALL_PRESET_INFO;
-
-    /**
-     * Preset Info notification reason.
-     * @hide
-     */
-    public static final int PRESET_INFO_REASON_PRESET_INFO_UPDATE =
-            IBluetoothHapClient.PRESET_INFO_REASON_PRESET_INFO_UPDATE;
-
-    /**
-     * Preset Info notification reason.
-     * @hide
-     */
-    public static final int PRESET_INFO_REASON_PRESET_DELETED =
-            IBluetoothHapClient.PRESET_INFO_REASON_PRESET_DELETED;
-
-    /**
-     * Preset Info notification reason.
-     * @hide
-     */
-    public static final int PRESET_INFO_REASON_PRESET_AVAILABILITY_CHANGED =
-            IBluetoothHapClient.PRESET_INFO_REASON_PRESET_AVAILABILITY_CHANGED;
-
-    /**
-     * Preset Info notification reason.
-     * @hide
-     */
-    public static final int PRESET_INFO_REASON_PRESET_INFO_REQUEST_RESPONSE =
-            IBluetoothHapClient.PRESET_INFO_REASON_PRESET_INFO_REQUEST_RESPONSE;
-
-    /**
-     * Represents invalid group identifier. It's returned when user requests a group identifier
-     * for a device which is not part of any group. This value shouldn't be used in the API calls.
-     * @hide
-     */
-    public static final int HAP_GROUP_UNAVAILABLE = IBluetoothHapClient.GROUP_ID_UNAVAILABLE;
-
     private final BluetoothAdapter mAdapter;
     private final AttributionSource mAttributionSource;
     private final BluetoothProfileConnector<IBluetoothHapClient> mProfileConnector =
@@ -621,8 +396,31 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
         if (callback == null) {
             throw new IllegalArgumentException("callback cannot be null");
         }
+        if (mCallbackDelegate != null) {
+            throw new IllegalStateException("app can register callback only once");
+        }
+        if (!isEnabled()) {
+            throw new IllegalStateException("service not enabled");
+        }
+
         if (DBG) log("registerCallback");
-        throw new UnsupportedOperationException("Not Implemented");
+
+        final IBluetoothHapClient service = getService();
+        if (service == null) {
+            Log.w(TAG, "Proxy not attached to service");
+            if (DBG) log(Log.getStackTraceString(new Throwable()));
+            return;
+        }
+
+        try {
+            final SynchronousResultReceiver<Integer> recv = new SynchronousResultReceiver();
+            service.registerCallback(mCallbackDelegate, mAttributionSource, recv);
+            recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(null);
+        } catch (TimeoutException e) {
+            Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+        } catch (RemoteException e) {
+            throw e.rethrowFromSystemServer();
+        }
     }
 
     /**
@@ -647,7 +445,26 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
             throw new IllegalArgumentException("callback cannot be null");
         }
         if (DBG) log("unregisterCallback");
-        throw new UnsupportedOperationException("Not Implemented");
+
+        final IBluetoothHapClient service = getService();
+        if (service == null) {
+            Log.w(TAG, "Proxy not attached to service");
+            if (DBG) log(Log.getStackTraceString(new Throwable()));
+            return;
+        }
+
+        try {
+            if (mCallbackDelegate != null) {
+                final SynchronousResultReceiver<Integer> recv = new SynchronousResultReceiver();
+                service.unregisterCallback(mCallbackDelegate, mAttributionSource, recv);
+                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(null);
+                mCallbackDelegate = null;
+            }
+        } catch (TimeoutException e) {
+            Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+        } catch (RemoteException e) {
+            throw e.rethrowFromSystemServer();
+        }
     }
 
     /**
@@ -683,8 +500,10 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
                 final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
                 service.setConnectionPolicy(device, connectionPolicy, mAttributionSource, recv);
                 return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
+            } catch (TimeoutException e) {
                 Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
         return defaultValue;
@@ -719,8 +538,10 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
                 final SynchronousResultReceiver<Integer> recv = new SynchronousResultReceiver();
                 service.getConnectionPolicy(device, mAttributionSource, recv);
                 return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
+            } catch (TimeoutException e) {
                 Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
         return defaultValue;
@@ -749,8 +570,10 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
                 final SynchronousResultReceiver<List> recv = new SynchronousResultReceiver();
                 service.getConnectedDevices(mAttributionSource, recv);
                 return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
+            } catch (TimeoutException e) {
                 Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
         return defaultValue;
@@ -780,8 +603,10 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
                 final SynchronousResultReceiver<List> recv = new SynchronousResultReceiver();
                 service.getDevicesMatchingConnectionStates(states, mAttributionSource, recv);
                 return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
+            } catch (TimeoutException e) {
                 Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
         return defaultValue;
@@ -811,8 +636,10 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
                 final SynchronousResultReceiver<Integer> recv = new SynchronousResultReceiver();
                 service.getConnectionState(device, mAttributionSource, recv);
                 return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
+            } catch (TimeoutException e) {
                 Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
         return defaultValue;
@@ -828,12 +655,11 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
      * require individual device calls.
      *
      * <p>Note that some binaural HA devices may not support group operations,
-     * therefore are not considered a valid HAP group. In such case the
-     * {@link #HAP_GROUP_UNAVAILABLE} is returned even when such
-     * device is a valid Le Audio Coordinated Set member.
+     * therefore are not considered a valid HAP group. In such case -1 is returned
+     * even if such device is a valid Le Audio Coordinated Set member.
      *
      * @param device
-     * @return valid group identifier or {@link #HAP_GROUP_UNAVAILABLE}
+     * @return valid group identifier or -1
      * @hide
      */
     @RequiresBluetoothConnectPermission
@@ -843,7 +669,7 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     })
     public int getHapGroup(@NonNull BluetoothDevice device) {
         final IBluetoothHapClient service = getService();
-        final int defaultValue = HAP_GROUP_UNAVAILABLE;
+        final int defaultValue = BluetoothCsipSetCoordinator.GROUP_ID_INVALID;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
@@ -852,8 +678,10 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
                 final SynchronousResultReceiver<Integer> recv = new SynchronousResultReceiver();
                 service.getHapGroup(device, mAttributionSource, recv);
                 return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
+            } catch (TimeoutException e) {
                 Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
         return defaultValue;
@@ -878,14 +706,15 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled() && isValidDevice(device)) {
-            // TODO(b/216639668)
-            // try {
-            //     final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-            //     service.getActivePresetIndex(device, mAttributionSource, recv);
-            //     return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            // } catch (RemoteException | TimeoutException e) {
-            //     Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
-            // }
+            try {
+                final SynchronousResultReceiver<Integer> recv = new SynchronousResultReceiver();
+                service.getActivePresetIndex(device, mAttributionSource, recv);
+                return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
+            } catch (TimeoutException e) {
+                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
+            }
         }
         return defaultValue;
     }
@@ -905,8 +734,25 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
             android.Manifest.permission.BLUETOOTH_PRIVILEGED
     })
     public @Nullable BluetoothHapPresetInfo getActivePresetInfo(@NonNull BluetoothDevice device) {
-        // TODO(b/216639668)
-        return null;
+        final IBluetoothHapClient service = getService();
+        final BluetoothHapPresetInfo defaultValue = null;
+        if (service == null) {
+            Log.w(TAG, "Proxy not attached to service");
+            if (DBG) log(Log.getStackTraceString(new Throwable()));
+        } else if (isEnabled() && isValidDevice(device)) {
+            try {
+                final SynchronousResultReceiver<BluetoothHapPresetInfo> recv =
+                        new SynchronousResultReceiver();
+                service.getActivePresetInfo(device, mAttributionSource, recv);
+                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
+            } catch (TimeoutException e) {
+                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
+            }
+        }
+
+        return defaultValue;
     }
 
     /**
@@ -928,18 +774,14 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     })
     public void selectPreset(@NonNull BluetoothDevice device, int presetIndex) {
         final IBluetoothHapClient service = getService();
-        final boolean defaultValue = false;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled() && isValidDevice(device)) {
             try {
-                // TODO(b/216639668)
-                final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-                service.selectActivePreset(device, presetIndex, mAttributionSource, recv);
-                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
-                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+                service.selectPreset(device, presetIndex, mAttributionSource);
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
     }
@@ -968,18 +810,14 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     })
     public void selectPresetForGroup(int groupId, int presetIndex) {
         final IBluetoothHapClient service = getService();
-        final boolean defaultValue = false;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled()) {
             try {
-                // TODO(b/216639668)
-                final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-                service.groupSelectActivePreset(groupId, presetIndex, mAttributionSource, recv);
-                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
-                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+                service.selectPresetForGroup(groupId, presetIndex, mAttributionSource);
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
     }
@@ -1000,18 +838,14 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     })
     public void switchToNextPreset(@NonNull BluetoothDevice device) {
         final IBluetoothHapClient service = getService();
-        final boolean defaultValue = false;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled() && isValidDevice(device)) {
             try {
-                // TODO(b/216639668)
-                final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-                service.nextActivePreset(device, mAttributionSource, recv);
-                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
-                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+                service.switchToNextPreset(device, mAttributionSource);
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
     }
@@ -1034,18 +868,14 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     })
     public void switchToNextPresetForGroup(int groupId) {
         final IBluetoothHapClient service = getService();
-        final boolean defaultValue = false;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled()) {
             try {
-                // TODO(b/216639668)
-                final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-                service.groupNextActivePreset(groupId, mAttributionSource, recv);
-                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
-                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+                service.switchToNextPresetForGroup(groupId, mAttributionSource);
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
     }
@@ -1066,18 +896,14 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     })
     public void switchToPreviousPreset(@NonNull BluetoothDevice device) {
         final IBluetoothHapClient service = getService();
-        final boolean defaultValue = false;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled() && isValidDevice(device)) {
             try {
-                // TODO(b/216639668)
-                final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-                service.previousActivePreset(device, mAttributionSource, recv);
-                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
-                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+                service.switchToPreviousPreset(device, mAttributionSource);
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
     }
@@ -1100,18 +926,14 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     })
     public void switchToPreviousPresetForGroup(int groupId) {
         final IBluetoothHapClient service = getService();
-        final boolean defaultValue = false;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled()) {
             try {
-                // TODO(b/216639668)
-                final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-                service.groupPreviousActivePreset(groupId, mAttributionSource, recv);
-                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
-                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+                service.switchToPreviousPresetForGroup(groupId, mAttributionSource);
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
     }
@@ -1129,24 +951,26 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
             android.Manifest.permission.BLUETOOTH_CONNECT,
             android.Manifest.permission.BLUETOOTH_PRIVILEGED
     })
-    public @NonNull BluetoothHapPresetInfo getPresetInfo(@NonNull BluetoothDevice device,
+    public @Nullable BluetoothHapPresetInfo getPresetInfo(@NonNull BluetoothDevice device,
             int presetIndex) {
         final IBluetoothHapClient service = getService();
-        final BluetoothHapPresetInfo.Builder builder = new BluetoothHapPresetInfo.Builder();
+        final BluetoothHapPresetInfo defaultValue = null;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled() && isValidDevice(device)) {
-            // TODO(b/216639668)
-            // try {
-            //     final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-            //     service.getPresetInfo(device, presetIndex, mAttributionSource, recv);
-            //     return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(builder);
-            // } catch (RemoteException | TimeoutException e) {
-            //     Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
-            // }
+            try {
+                final SynchronousResultReceiver<BluetoothHapPresetInfo> recv =
+                        new SynchronousResultReceiver();
+                service.getPresetInfo(device, presetIndex, mAttributionSource, recv);
+                return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
+            } catch (TimeoutException e) {
+                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
+            }
         }
-        return builder.build();
+        return defaultValue;
     }
 
     /**
@@ -1169,14 +993,16 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled() && isValidDevice(device)) {
-            // TODO(b/216639668)
-            // try {
-            //     final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-            //     service.getAllPresetsInfo(device, mAttributionSource, recv);
-            //     return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            // } catch (RemoteException | TimeoutException e) {
-            //     Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
-            // }
+            try {
+                final SynchronousResultReceiver<List<BluetoothHapPresetInfo>> recv =
+                        new SynchronousResultReceiver();
+                service.getAllPresetInfo(device, mAttributionSource, recv);
+                return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
+            } catch (TimeoutException e) {
+                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
+            }
         }
         return defaultValue;
     }
@@ -1193,19 +1019,21 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
             android.Manifest.permission.BLUETOOTH_CONNECT,
             android.Manifest.permission.BLUETOOTH_PRIVILEGED
     })
-    public boolean getFeatures(@NonNull BluetoothDevice device) {
+    public int getFeatures(@NonNull BluetoothDevice device) {
         final IBluetoothHapClient service = getService();
-        final boolean defaultValue = false;
+        final int defaultValue = 0x00;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled() && isValidDevice(device)) {
             try {
-                final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
+                final SynchronousResultReceiver<Integer> recv = new SynchronousResultReceiver();
                 service.getFeatures(device, mAttributionSource, recv);
                 return recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
+            } catch (TimeoutException e) {
                 Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
         return defaultValue;
@@ -1235,18 +1063,14 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     public void setPresetName(@NonNull BluetoothDevice device, int presetIndex,
             @NonNull String name) {
         final IBluetoothHapClient service = getService();
-        final boolean defaultValue = false;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled() && isValidDevice(device)) {
             try {
-                // TODO(b/216639668)
-                final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-                service.setPresetName(device, presetIndex, name, mAttributionSource, recv);
-                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
-                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+                service.setPresetName(device, presetIndex, name, mAttributionSource);
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
     }
@@ -1274,18 +1098,14 @@ public final class BluetoothHapClient implements BluetoothProfile, AutoCloseable
     })
     public void setPresetNameForGroup(int groupId, int presetIndex, @NonNull String name) {
         final IBluetoothHapClient service = getService();
-        final boolean defaultValue = false;
         if (service == null) {
             Log.w(TAG, "Proxy not attached to service");
             if (DBG) log(Log.getStackTraceString(new Throwable()));
         } else if (isEnabled()) {
             try {
-                // TODO(b/216639668)
-                final SynchronousResultReceiver<Boolean> recv = new SynchronousResultReceiver();
-                service.groupSetPresetName(groupId, presetIndex, name, mAttributionSource, recv);
-                recv.awaitResultNoInterrupt(getSyncTimeout()).getValue(defaultValue);
-            } catch (RemoteException | TimeoutException e) {
-                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));
+                service.setPresetNameForGroup(groupId, presetIndex, name, mAttributionSource);
+            } catch (RemoteException e) {
+                throw e.rethrowFromSystemServer();
             }
         }
     }