diff options
| author | Jack He <siyuanh@google.com> | 2017-08-22 21:21:23 -0700 |
|---|---|---|
| committer | Jack He <siyuanh@google.com> | 2017-08-24 19:09:58 +0000 |
| commit | 9e045d26d0128826b40520f523307d8d16473779 (patch) | |
| tree | 8299c300f3b4dbc2a5360c3319ac41bf1b389e55 /framework/java/android/bluetooth/BluetoothAdapter.java | |
| parent | 910201beb0bde1dcf6b33e4ec5d1eb60042419d8 (diff) | |
Fix checkstyle errors (2/2)
* Manual style corrections with IDE assistance
* Variable name refactors are done through IDE
* Corrected general style errors such as:
- "final private var" -> "private final var"
- "&&", "+", "||" should not be at the end of line
- Non-static private variable should be like "mVar"
- Private static variable should be like "sVar"
- Code file should always end with newline
- Inherited methods should be annotated with @Override
and no @hide tags
- Public methods should always have a JavaDoc entry
- "int[] array" is preferred over "int array[]"
- private methods should be accessed without "this."
when there is no name collisions.
- "boolean ? true : false" -> boolean
- "boolean ? false : true" -> !boolean
- "boolean == true" OR "boolean != false" -> boolean
- "boolean != true" OR "boolean == false" -> !boolean
Bug: 63596319
Test: make checkbuild, no functional changes
Change-Id: Iabdc2be912a32dd63a53213d175cf1bfef268ccd
Diffstat (limited to 'framework/java/android/bluetooth/BluetoothAdapter.java')
| -rw-r--r-- | framework/java/android/bluetooth/BluetoothAdapter.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/framework/java/android/bluetooth/BluetoothAdapter.java b/framework/java/android/bluetooth/BluetoothAdapter.java index 1b9ce88de0..70591d4d05 100644 --- a/framework/java/android/bluetooth/BluetoothAdapter.java +++ b/framework/java/android/bluetooth/BluetoothAdapter.java @@ -2191,7 +2191,7 @@ public final class BluetoothAdapter { } } - final private IBluetoothManagerCallback mManagerCallback = + private final IBluetoothManagerCallback mManagerCallback = new IBluetoothManagerCallback.Stub() { public void onBluetoothServiceUp(IBluetooth bluetoothService) { if (DBG) Log.d(TAG, "onBluetoothServiceUp: " + bluetoothService); @@ -2255,7 +2255,7 @@ public final class BluetoothAdapter { * @hide */ public boolean enableNoAutoConnect() { - if (isEnabled() == true) { + if (isEnabled()) { if (DBG) Log.d(TAG, "enableNoAutoConnect(): BT already enabled!"); return true; } @@ -2376,7 +2376,7 @@ public final class BluetoothAdapter { return mManagerService; } - final private ArrayList<IBluetoothManagerCallback> mProxyServiceStateCallbacks = + private final ArrayList<IBluetoothManagerCallback> mProxyServiceStateCallbacks = new ArrayList<IBluetoothManagerCallback>(); /*package*/ IBluetooth getBluetoothService(IBluetoothManagerCallback cb) { |