summaryrefslogtreecommitdiff
path: root/src/com/android/settings/wifi/WifiConfigController.java
AgeCommit message (Collapse)Author
2022-05-02Revert "[Wi-Fi] Remove 'Do not validate' option in CA certificate spinner"TogoFire
This is not a definitive fix, so revert it. WPA2-Enterprise (802.1X) or WPA2-PSK. [xawlw]: - Sometimes we can't connect to some Enterprise WiFi networks because we don't know its domain so let's revert this 'Security' feature - Read more about it here: https://www.xda-developers.com/android-11-break-enterprise-wifi-connection/ This reverts commit 33cde5dbeee934269f16d72e26e651d56a13733e. This reverts commit 94b8579607c6f1201cea9d6601e88cec897b2ff6. Signed-off-by: TogoFire <italomellopereira@gmail.com> Signed-off-by: xawlw <abdulazizawlw@gmail.com> Change-Id: I3cec92b74a419b5463c5e5db496863e66d034703
2021-12-06To get Display name by active subscription infochangbetty
Bug: 206601918 Test: manual test and test team verified pass Change-Id: Id156b3c5c65ff3af25f74721db27f46c08f3543e
2021-03-18Remove hidden connectivity methods accessChiachang Wang
This commit resolves the hidden methods accesses for LinkProperties, IpConfiguration and RouteInfo with atlernative way for the connectivity mainline module preparation. Bug: 172183305 Test: make RunSettingsRoboTests ROBOTEST_FILTER=\ com.android.settings.wifi.details2.WifiDetailPreferenceController2Test Test: make RunSettingsRoboTests ROBOTEST_FILTER=\ com.android.settings.wifi.details.WifiDetailPreferenceControllerTest Test: make RunSettingsRoboTests ROBOTEST_FILTER=\ com.android.settings.UtilsTest Test: make RunSettingsRoboTests ROBOTEST_FILTER=\ com.android.settings.wifi.WifiConfigController2Test Test: make RunSettingsRoboTests ROBOTEST_FILTER=\ com.android.settings.wifi.WifiConfigController2Test Change-Id: Iec4dab5d9fa12dedcf69a1cfe2a8be0956bc0d79
2021-03-18Merge "Replace the hidden ProxyInfo methods usage" am: 2f66e59e05 am: ↵Chiachang Wang
3ad73342c7 am: 168298f426 Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1641827 Change-Id: Ie8f4aad4c3d89e5b06800d61719478d6b4b7afdd
2021-03-18Merge "Replace the way to access StaticIpConfiguration" am: dd61e5d664 am: ↵Chiachang Wang
cda53ebeae am: f60f9ec14c Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1641821 Change-Id: I904f5ec889d40113bf232f7935a98c6da030c9c3
2021-03-17Replace the hidden ProxyInfo methods usageChiachang Wang
The hidden ProxyInfo methods usage should be replaced because ProxyInfo is moving to connectivity mainline module. Setting will not be able to access it. Replace the usage with corresponding APIs. Bug: 172183305 Test: make RunSettingsRoboTests ROBOTEST_FILTER=\ com.android.settings.wifi.WifiConfigControllerTest Test: make RunSettingsRoboTests ROBOTEST_FILTER=\ com.android.settings.wifi.WifiConfigController2Test Test: manually update proxy from setting and check the result Change-Id: I59192d0d5d38c833eb83cc930e358a738ebe3d13
2021-03-17Replace the way to access StaticIpConfigurationChiachang Wang
StaticIpConfiguration is a part of incoming connectivity mainline module. The hidden variable is not accessible for module outside. The caller should use getter and builder to access it. Replace the usage with the formal way. Test: make RunSettingsRoboTests ROBOTEST_FILTER=\ com.android.settings.wifi.WifiConfigControllerTest Test: make RunSettingsRoboTests ROBOTEST_FILTER=\ com.android.settings.wifi.WifiConfigController2Test Change-Id: I2ccd427ba19a4ec7df863c38ee0b34cf0be87fa5
2021-03-09Merge "Change ScrollView to NestedScrollView for wifi_dialog" into sc-devTreeHugger Robot
2021-03-09Change ScrollView to NestedScrollView for wifi_dialogArc Wang
After enabling collapsing toolbar, ScrollView is not working with CoordinatorLayout. So we need to update it to NestedScrollView to make it work with CoordinatorLayout. Bug: 182221182 Test: make RunSettingsLibRoboTests ROBOTEST_FILTER=com.android.settingslib.wifi manual visual In Settings -< Network & internet -> Wi-Fi -> Add network, select enterprise type and scroll the screen. Change-Id: Ie9de753ee198409275e818a123b5ba7f9b6a1e26
2021-03-05wifi: add WPA3 Enterprise entry in "Add network"Jimmy Chen
Bug: 174569407 Test: checked UI manually and stored configurations. Change-Id: I8a05bbb11e4a363c39a71d26513caf727d228b36
2021-03-03Keystore 2.0: Update Wifi settings to use mostly public keystore API.Janis Danisevskis
Test: N/A Bug: 171305607 Bug: 171305388 Merged-In: Ib794c5f2d904c2b187d7d5fd00b81afc852d0052 Change-Id: Ib794c5f2d904c2b187d7d5fd00b81afc852d0052
2021-02-25Keystore 2.0: Update Wifi settings to use mostly public keystore API.Janis Danisevskis
Test: N/A Bug: 171305607 Bug: 171305388 Merged-In: Ib794c5f2d904c2b187d7d5fd00b81afc852d0052 Change-Id: Ib794c5f2d904c2b187d7d5fd00b81afc852d0052
2021-02-22Replace NetworkUtils methodsChiachang Wang
NetworkUtils is moved to connectivity mainline module which is not accessible for module outside. getNetworkPart() method is used by wifi lib and Settings but no usage inside the module, so move the method to framework lib to share with wifi lib and Settings. Also, NetworkUtils.numericToInetAddress() method is also hidden and deprecated. It should be replaced by InetAddresses.parseNumericAddress(). Update the corresponding usage to refer to these methods. Bug: 172183305 Test: atest SettingsRoboTests Change-Id: I8240b1c74b53d5d66850d9a3ec7d5e5c11558e6a Merged-In: I2fb674e0d7da0b11ba70177853fd6259bce372a3
2021-02-04Replace NetworkUtils methodsChiachang Wang
NetworkUtils is moved to connectivity mainline module which is not accessible for module outside. getNetworkPart() method is used by wifi lib and Settings but no usage inside the module, so move the method to framework lib to share with wifi lib and Settings. Also, NetworkUtils.numericToInetAddress() method is also hidden and deprecated. It should be replaced by InetAddresses.parseNumericAddress(). Update the corresponding usage to refer to these methods. Bug: 172183305 Test: atest SettingsRoboTests Change-Id: I2fb674e0d7da0b11ba70177853fd6259bce372a3
2021-02-03Merge "Replace @hide API with public API" am: d52cff9b57 am: 3178dfc76a am: ↵Aaron Huang
68bdb8e8b8 Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1566248 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I71dd0c79cdf216746d57ea6686c3d8141c721a57
2021-02-01Replace @hide API with public APIAaron Huang
ProxyInfo is inculded in framework-connectivity module which should not have external dependencies on its hidden API. Thus, migrate getExclusionListAsString to getExclusionList. Bug: 178777253 Test: build Change-Id: I64b9d5be062bec43c7be3ea68d1f63054319df2d Change-Id: I400df793fc669d0e574fb4cf022d021d99859d53
2021-01-22SubscriptionsPreferenceController shows the unique sim description.Jeremy Goldman
Bug: 148303118 Bug: 150370656 Test: atest -c SubscriptionsPreferenceControllerTest Change-Id: I041536fe0148087a068c6000383b382b0ff4e17c
2021-01-12Clean up split system user code in packages/apps/Settings/Yan Zhu
Remove legacy code belonged to Andrometa project. Split system user feature is always turned off now. Bug: 137101239 Test: build, sync and reboot Change-Id: Ieb84a6e131383dcd263a5d9b29a49dc64d905fe0
2020-08-07Merge "[Wi-Fi] Support multi-SIM for SIM dependent EAP methods" into ↵TreeHugger Robot
rvc-qpr-dev am: edd587c2a6 am: 48d768b00c Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12167384 Change-Id: I559cee4b76432f72cab16b926ad7d8a2f87abedc
2020-08-07Merge "[Wi-Fi] Support multi-SIM for SIM dependent EAP methods" into rvc-qpr-devTreeHugger Robot
2020-08-01Merge "[Wi-Fi] Remove 'Do not validate' option in CA certificate spinner"Arc Wang
2020-07-31[Wi-Fi] Remove 'Do not validate' option in CA certificate spinnerArc Wang
"Do not validate" is not secure and must not be used in any production network. R Suggestions API already does not allow connections with no Root CA certificate. Bug: 162466484 Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigControllerTest make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigController2Test Manually add or edit an EAP method Wi-Fi network and observe CA certificate spinner options. Change-Id: Ica5ecf8805c51d7cdce7b16e02e0dd79d5f64754 Merged-In: Icf97199967faa2e359b0120a8c989bd1df2c6cea
2020-07-31Merge "[Wi-Fi] Check if domain field is not empty when users choose a ca ↵Arc Wang
certificate"
2020-07-31[Wi-Fi] Check if domain field is not empty when users choose a ca certificateArc Wang
Domain is required for client to validate server's certificate. This change disable Save button for a new Wi-Fi network of a specified CA certificate but empty domain. Bug: 161378819 Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigControllerTest make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigController2Test manual 1. Install a certificate. 2. Add a new Wi-Fi network of EAP method PEAP 3. Set CA certificate to the certificate installed at 1. 4. Save button should be disabled. 5. Input something in domain field. 6. Save button should be enabled. Change-Id: I65c8b29ec7a03b21403ddbfc087ce48c2a4a69e4
2020-07-31[Wi-Fi] Remove 'Do not validate' option in CA certificate spinnerArc Wang
"Do not validate" is not secure and must not be used in any production network. R Suggestions API already does not allow connections with no Root CA certificate. Bug: 162466484 Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigControllerTest make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigController2Test Manually add or edit an EAP method Wi-Fi network and observe CA certificate spinner options. Change-Id: Icf97199967faa2e359b0120a8c989bd1df2c6cea
2020-07-29[Wi-Fi] Check if domain field is not empty when users choose a ca certificateArc Wang
Domain is required for client to validate server's certificate. This change disable Save button for a new Wi-Fi network of a specified CA certificate but empty domain. Bug: 161378819 Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigControllerTest make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigController2Test manual 1. Install a certificate. 2. Add a new Wi-Fi network of EAP method PEAP 3. Set CA certificate to the certificate installed at 1. 4. Save button should be disabled. 5. Input something in domain field. 6. Save button should be enabled. Change-Id: I65c8b29ec7a03b21403ddbfc087ce48c2a4a69e4
2020-07-28[Wi-Fi] Remove the files which use SettingsLib Wi-Fi objectsArc Wang
This change removes WifiDetailPreferenceController WifiPrivacyPreferenceController Bug: 152571756 Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigControllerTest Manualy add a Wi-Fi network of randomized MAC and a Wi-Fi network of device MAC in SetupWizard, then observe the MAC value in Settings Wi-Fi detail. Change-Id: I82ef4e1d2c386d8bd751df8ff18c18163a0e9a6a
2020-07-28[Wi-Fi] Support multi-SIM for SIM dependent EAP methodsArc Wang
Before this change, users are not able to choose SIM card for SIM dependent EAP methods when a device supports multi-SIM. This change support to choose a SIM when adding an EAP Wi-Fi network. And this change support to show the related SIM information on Wi-Fi detail screen. Bug: 142792009 Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.WifiConfigControllerTest make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.WifiConfigController2Test make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.details2.WifiDetailPreferenceController2Test Manually add an EAP Wi-Fi network of EAP-SIM type, observe the value in Wi-Fi detail screen. Change-Id: I2910931166dc6541897663857c46abcc1b3115fa
2020-04-27[Wi-Fi] Add object comments for WifiTrackerLib migrationArc Wang
Migrating from Wi-Fi SettingsLib to to WifiTrackerLib, there are both some Settings files of both version. Developers should develop on new version files. Bug: 152571756 Test: compile Change-Id: I4446e2e333663bf69daa1ceff102775889021851
2020-04-10Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-devArc Wang
2020-04-10[Wi-Fi] Fix Hidden network option scrolls to bottom problemArc Wang
Should not scroll to bottom since Hidden network option is not at the bottom most. Bug: 148036155 Test: manual Wi-Fi Setings -> Add network -> Advanced options -> click 'Hidden network' Yes -> should not scroll to bottom. Change-Id: I6511f75441ebad62e2c28df76a39d702d78898a6
2020-04-09[A11Y][Wi-Fi] Fix multiple Spinner selected speak out at once.Arc Wang
When users select edit a Wi-Fi and select enterprise security, there are multiple spinner shows with a default value. This change does not allow TalkBack to speak out for multiple Spinner text at one user selection. Bug: 153272108 Test: manual Wi-Fi Settings -> Add network -> Security spinner -> WPA/WPA2/WPA3-Enterprise TalkBack should only speak out for the Security spinner. Change-Id: Id9ab44e4da6d7abb5168e0ab7441ee1e226f5f68
2020-03-09[Settings] Use WifiConfiguration#setSecurityParamsHai Shalom
Use WifiConfiguration#setSecurityParams instead of manually initializing security params. Bug: 150889755 Test: Created new connections and manually connected to open, WPA2, WPA3, EAP and SUITE-B networks. Change-Id: I42f4c21a37428ee87be14f6ba09dc54fa327054a
2020-02-24[Wi-Fi] Ignore incorrect user certificatesArc Wang
These incorrect user certificates displayed when users editing a Wi-Fi network of WPA3-Enterprise in 192bit. Bug: 149763958 Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigControllerTest make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigControllerTest2 Change-Id: Iab35ac975933abc54fda83b99a2109d53d6722d4
2020-02-14Merge "Rename requirePMF to requirePmf"David Su
2020-01-30Settings: remove usage of WifiConfig helper methodsDavid Su
These methods can be replaced with methods on IpConfiguration itself. There is no need to expose these as a @SystemApi, and they are being removed. Bug: 146046526 Test: make RunSettingsRoboTests -j40 Change-Id: I592f277f5e23bf58e76b8c48a0f0370d53cc6b81
2020-01-27Rename requirePMF to requirePmfDavid Su
Rename to conform to API guidelines. Bug: 146046526 Test: compiles Change-Id: Ib888ca3fc14cf30c9217b1f573c2279627c65a22
2020-01-10[Wi-Fi] Revert "support SAE password identifier in wifi dialog"Arc Wang
Revert it because SPEC is not clear now. Bug: 143379656 Test: manual Click "Add network" in wi-Fi picker and edit a WAP3-personal Wi-Fi network Change-Id: Ifa859d53c29d0fa83f22cc2d0e50294d0a5c7fc9
2019-12-30[Wi-Fi] Hide the Advanced Option after expanding the advanced option fields.govenliu
To align with other advanced option behaviors in other Settings items, hide the Advanced Option button after the hidden advanced options are show, which also solve the a11y issue. Bug: 146908469 Test: Add test case getVisibility_whenAdvancedOptionClicked_shouldBeGone to verify View is Gone. Change-Id: I11b2f9b250a7d50d32b8c05207498f4cf14feb41
2019-12-12Remove those stuff about CarrierAp, they are removed from FW.Steven Liu
Bug: 130875004 Test: atest SettingsRoboTests Change-Id: I549eabd1699a617dd6e639b725ade361c64d5a67
2019-12-06[Wi-Fi] Fix transition mode problemsArc Wang
Replace SECURITY_PSK_SAE_TRANSITION & SECURITY_OWE_TRANSITION with AccessPpoint#isPskSaeTransitionMode() & AccessPpoint#isPskOweTransitionMode() Bug: 144320676 Bug: 144320649 Bug: 144325162 Bug: 144321574 Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi Change-Id: Ic3c7ac1238a51b6e215ed63761720d2bc371d012
2019-11-20[Wi-Fi] Force users to select a phase2 authentication for PEAP & TTLSArc Wang
To improve security. Bug: 143601727 Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigControllerTest Change-Id: I0cb1ceda6d89a52224f80ea5ffd1af709a6acace
2019-11-15[Wi-Fi] Create WifiNetworkDetailsFragment related version 2 files for ↵Arc Wang
WifiTracker2 development Create below version 2 files for WifiTracker2 development, we can check the feature flag only a few times and easily remove version 1 files in the future. src/com/android/settings/wifi/details2/ src/com/android/settings/wifi/savedaccesspoints2/ tests/robotests/src/com/android/settings/wifi/details2/ tests/robotests/src/com/android/settings/wifi/savedaccesspoints2/ Bug: 143326832 Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi.details2 make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi.savedaccesspoints2 Change-Id: I4d2caf1ce313871605252395764b02747240f217
2019-11-06Settings: Use public API for mac randomization supportRoshan Pius
Also, don't directly reference the default tether ssid overlay. This info should always be retrieved from wifiManager. This ensures that we don't use wifi overlays in settings. Bug: 143464763 Test: atest com.android.server.wifi Change-Id: I893a4ca0f4243e1eb6f9c8bef810d0b4a493fb88
2019-10-24Merge "Replace getNetworkPrefixLength() with public API" am: f67076dad5 am: ↵Aaron Huang
7b82097220 am: 5b182f20cb am: 9c39357454 Change-Id: Id0f3c816bb95d891cfb9f0109c0afedb7494f222
2019-10-24Merge "Replace getNetworkPrefixLength() with public API" am: f67076dad5 am: ↵Aaron Huang
7b82097220 am: 5b182f20cb Change-Id: Ib6f188586b486fa5af0a8df57a65db654f66e311
2019-10-24Replace getNetworkPrefixLength() with public APIAaron Huang
Use public API getPrefixLength() instead Test: build pass Change-Id: Ib85aa12dc22ac5b03c9bb7101beaf340014eb4fd
2019-10-17[Wi-Fi] [a11y] The "Advanced options" should be accessible by Voice Access ↵govenliu
and pronounced by talkback correctly. The checkbox is unclickable via Accessibility. Solution: Refine the solution of b/30079196 to let checkbox be focusable and clickable by Accessibility, and remove unnecessary Accessibility pronunciation strings. Bug: 141588638 Bug: 141588161 Test: Add unit test to check the content description of the checkbox. Change-Id: I2e7932f64ae29a13b793276eab6705009af20104
2019-09-23[Wi-Fi] Improve UX when there is no user certificate to choose for ↵Arc Wang
WPA-Enterprise 192-bit Show error message when a user does not specify a user certificate for WPA3-Enterprise 192-bit. Bug: 138417816 Test: visual Change-Id: Ifc519d484dbf78dad37ad7047e8b9bb40685d54c
2019-09-10[Wi-Fi] Fix robolectric test brokenArc Wang
1. WifiConfigController#setSelection triggers onItemSelect, it uses mEapUserCertSpinner without adapter. 2. refreshSummary should use parameter preference instead of mPreference. Bug: 140771897 Test: WifiConfigControllerTest WifiWakeupPreferenceControllerTest Change-Id: I963260bd82e7387052cacae89bdbe46da841e341
generated by cgit v1.2.3 (git 2.25.1) at 2025-10-03 16:27:30 +0000