summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColin Marsch <colinmarsch@google.com>2020-08-17 12:49:28 -0500
committerMichael Bestas <mkbestas@lineageos.org>2020-12-08 19:39:11 +0200
commit676ae03d8722bc6830a8c150e795cc6adf3710ea (patch)
tree629ea0a71472988e743a93795112bfb13349f046
parent96c7cd5ba710435cbaf36edd7d629b73772bb062 (diff)
AOSP/DeskClock - Update Fragment related code to use AndroidX
Kotlin AndroidX upgrades, as well as Java AndroidX upgrades to ensure both DeskClock and DeskClockJava targets pass the tests. Test: manual, tested the DeskClock UI. As well tests were ran as follows $ source build/envsetup.sh $ lunch aosp_sargo-userdebug $ make DeskClock $ adb install out/target/product/sargo/product/app/DeskClock/DeskClock.apk $ atest DeskClockTests $ make DeskClockJava $ adb install out/target/product/sargo/product/app/DeskClockJava/DeskClockJava.apk $ atest DeskClockTests BUG: 157255731 Change-Id: I4e038932e913a125265bcf5c0091f69e34ec16ce
-rw-r--r--src/com/android/deskclock/AlarmClockFragment.java17
-rw-r--r--src/com/android/deskclock/DeskClock.java19
-rw-r--r--src/com/android/deskclock/DeskClockFragment.java6
-rw-r--r--src/com/android/deskclock/FragmentTabPagerAdapter.java23
-rw-r--r--src/com/android/deskclock/LabelDialogFragment.java14
-rw-r--r--src/com/android/deskclock/alarms/AlarmTimeClickHandler.java4
-rw-r--r--src/com/android/deskclock/alarms/TimePickerDialogFragment.java8
-rw-r--r--src/com/android/deskclock/provider/Alarm.java2
-rw-r--r--src/com/android/deskclock/timer/TimerFragment.java2
-rw-r--r--src/com/android/deskclock/timer/TimerItemFragment.java2
-rw-r--r--src/com/android/deskclock/timer/TimerPagerAdapter.java14
11 files changed, 56 insertions, 55 deletions
diff --git a/src/com/android/deskclock/AlarmClockFragment.java b/src/com/android/deskclock/AlarmClockFragment.java
index 5c02d0316..8198b58ba 100644
--- a/src/com/android/deskclock/AlarmClockFragment.java
+++ b/src/com/android/deskclock/AlarmClockFragment.java
@@ -16,24 +16,23 @@
package com.android.deskclock;
-import android.app.LoaderManager;
import android.content.Context;
import android.content.Intent;
-import android.content.Loader;
import android.database.Cursor;
import android.graphics.drawable.Drawable;
import android.os.Bundle;
import android.os.SystemClock;
-import androidx.annotation.NonNull;
-import com.google.android.material.snackbar.Snackbar;
-import androidx.recyclerview.widget.LinearLayoutManager;
-import androidx.recyclerview.widget.RecyclerView;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.Button;
import android.widget.ImageView;
import android.widget.TextView;
+import androidx.annotation.NonNull;
+import androidx.loader.app.LoaderManager;
+import androidx.loader.content.Loader;
+import androidx.recyclerview.widget.LinearLayoutManager;
+import androidx.recyclerview.widget.RecyclerView;
import com.android.deskclock.alarms.AlarmTimeClickHandler;
import com.android.deskclock.alarms.AlarmUpdateHandler;
@@ -49,6 +48,8 @@ import com.android.deskclock.widget.EmptyViewController;
import com.android.deskclock.widget.toast.SnackbarManager;
import com.android.deskclock.widget.toast.ToastManager;
+import com.google.android.material.snackbar.Snackbar;
+
import java.util.ArrayList;
import java.util.List;
@@ -102,7 +103,7 @@ public final class AlarmClockFragment extends DeskClockFragment implements
@Override
public void onCreate(Bundle savedState) {
super.onCreate(savedState);
- mCursorLoader = getLoaderManager().initLoader(0, null, this);
+ mCursorLoader = LoaderManager.getInstance(this).initLoader(0, null, this);
if (savedState != null) {
mExpandedAlarmId = savedState.getLong(KEY_EXPANDED_ID, Alarm.INVALID_ID);
}
@@ -186,7 +187,7 @@ public final class AlarmClockFragment extends DeskClockFragment implements
super.onStart();
if (!isTabSelected()) {
- TimePickerDialogFragment.removeTimeEditDialog(getFragmentManager());
+ TimePickerDialogFragment.removeTimeEditDialog(getParentFragmentManager());
}
}
diff --git a/src/com/android/deskclock/DeskClock.java b/src/com/android/deskclock/DeskClock.java
index e53fbebb6..a6a36628f 100644
--- a/src/com/android/deskclock/DeskClock.java
+++ b/src/com/android/deskclock/DeskClock.java
@@ -20,17 +20,9 @@ import android.animation.Animator;
import android.animation.AnimatorListenerAdapter;
import android.animation.AnimatorSet;
import android.animation.ValueAnimator;
-import android.app.Fragment;
import android.content.Intent;
import android.graphics.drawable.Drawable;
import android.os.Bundle;
-import androidx.annotation.StringRes;
-import com.google.android.material.snackbar.Snackbar;
-import com.google.android.material.tabs.TabLayout;
-import androidx.viewpager.widget.ViewPager;
-import androidx.viewpager.widget.ViewPager.OnPageChangeListener;
-import androidx.appcompat.app.ActionBar;
-import androidx.appcompat.widget.Toolbar;
import android.view.KeyEvent;
import android.view.Menu;
import android.view.MenuItem;
@@ -39,6 +31,12 @@ import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.ImageView;
import android.widget.TextView;
+import androidx.annotation.StringRes;
+import androidx.appcompat.app.ActionBar;
+import androidx.appcompat.widget.Toolbar;
+import androidx.fragment.app.Fragment;
+import androidx.viewpager.widget.ViewPager;
+import androidx.viewpager.widget.ViewPager.OnPageChangeListener;
import com.android.deskclock.actionbarmenu.MenuItemControllerFactory;
import com.android.deskclock.actionbarmenu.NightModeMenuItemController;
@@ -53,6 +51,9 @@ import com.android.deskclock.uidata.TabListener;
import com.android.deskclock.uidata.UiDataModel;
import com.android.deskclock.widget.toast.SnackbarManager;
+import com.google.android.material.snackbar.Snackbar;
+import com.google.android.material.tabs.TabLayout;
+
import static androidx.viewpager.widget.ViewPager.SCROLL_STATE_DRAGGING;
import static androidx.viewpager.widget.ViewPager.SCROLL_STATE_IDLE;
import static androidx.viewpager.widget.ViewPager.SCROLL_STATE_SETTLING;
@@ -392,7 +393,7 @@ public class DeskClock extends BaseActivity
*/
@Override
public void onDialogLabelSet(Alarm alarm, String label, String tag) {
- final Fragment frag = getFragmentManager().findFragmentByTag(tag);
+ final Fragment frag = getSupportFragmentManager().findFragmentByTag(tag);
if (frag instanceof AlarmClockFragment) {
((AlarmClockFragment) frag).setLabel(alarm, label);
}
diff --git a/src/com/android/deskclock/DeskClockFragment.java b/src/com/android/deskclock/DeskClockFragment.java
index a9e3fc659..1f51a332e 100644
--- a/src/com/android/deskclock/DeskClockFragment.java
+++ b/src/com/android/deskclock/DeskClockFragment.java
@@ -16,12 +16,12 @@
package com.android.deskclock;
-import android.app.Fragment;
-import androidx.annotation.ColorInt;
-import androidx.annotation.NonNull;
import android.view.KeyEvent;
import android.widget.Button;
import android.widget.ImageView;
+import androidx.annotation.ColorInt;
+import androidx.annotation.NonNull;
+import androidx.fragment.app.Fragment;
import com.android.deskclock.uidata.UiDataModel;
import com.android.deskclock.uidata.UiDataModel.Tab;
diff --git a/src/com/android/deskclock/FragmentTabPagerAdapter.java b/src/com/android/deskclock/FragmentTabPagerAdapter.java
index 3682c86e4..de3e25c35 100644
--- a/src/com/android/deskclock/FragmentTabPagerAdapter.java
+++ b/src/com/android/deskclock/FragmentTabPagerAdapter.java
@@ -16,14 +16,13 @@
package com.android.deskclock;
-import android.app.Fragment;
-import android.app.FragmentManager;
-import android.app.FragmentTransaction;
-import androidx.legacy.app.FragmentCompat;
-import androidx.viewpager.widget.PagerAdapter;
import android.util.ArrayMap;
import android.view.View;
import android.view.ViewGroup;
+import androidx.fragment.app.Fragment;
+import androidx.fragment.app.FragmentManager;
+import androidx.fragment.app.FragmentTransaction;
+import androidx.viewpager.widget.PagerAdapter;
import com.android.deskclock.uidata.UiDataModel;
@@ -55,7 +54,7 @@ final class FragmentTabPagerAdapter extends PagerAdapter {
FragmentTabPagerAdapter(DeskClock deskClock) {
mDeskClock = deskClock;
mFragmentCache = new ArrayMap<>(getCount());
- mFragmentManager = deskClock.getFragmentManager();
+ mFragmentManager = deskClock.getSupportFragmentManager();
}
@Override
@@ -119,8 +118,8 @@ final class FragmentTabPagerAdapter extends PagerAdapter {
}
if (fragment != mCurrentPrimaryItem) {
- FragmentCompat.setMenuVisibility(fragment, false);
- FragmentCompat.setUserVisibleHint(fragment, false);
+ fragment.setMenuVisibility(false);
+ fragment.setUserVisibleHint(false);
}
return fragment;
@@ -141,12 +140,12 @@ final class FragmentTabPagerAdapter extends PagerAdapter {
final Fragment fragment = (Fragment) object;
if (fragment != mCurrentPrimaryItem) {
if (mCurrentPrimaryItem != null) {
- FragmentCompat.setMenuVisibility(mCurrentPrimaryItem, false);
- FragmentCompat.setUserVisibleHint(mCurrentPrimaryItem, false);
+ mCurrentPrimaryItem.setMenuVisibility(false);
+ mCurrentPrimaryItem.setUserVisibleHint(false);
}
if (fragment != null) {
- FragmentCompat.setMenuVisibility(fragment, true);
- FragmentCompat.setUserVisibleHint(fragment, true);
+ fragment.setMenuVisibility(true);
+ fragment.setUserVisibleHint(true);
}
mCurrentPrimaryItem = fragment;
}
diff --git a/src/com/android/deskclock/LabelDialogFragment.java b/src/com/android/deskclock/LabelDialogFragment.java
index 0fa0eab0d..d997cdb78 100644
--- a/src/com/android/deskclock/LabelDialogFragment.java
+++ b/src/com/android/deskclock/LabelDialogFragment.java
@@ -17,18 +17,11 @@
package com.android.deskclock;
import android.app.Dialog;
-import android.app.DialogFragment;
-import android.app.Fragment;
-import android.app.FragmentManager;
-import android.app.FragmentTransaction;
import android.content.Context;
import android.content.DialogInterface;
import android.content.res.ColorStateList;
import android.graphics.Color;
import android.os.Bundle;
-import androidx.annotation.NonNull;
-import androidx.appcompat.app.AlertDialog;
-import androidx.appcompat.widget.AppCompatEditText;
import android.text.Editable;
import android.text.InputType;
import android.text.TextUtils;
@@ -37,6 +30,13 @@ import android.view.KeyEvent;
import android.view.Window;
import android.view.inputmethod.EditorInfo;
import android.widget.TextView;
+import androidx.annotation.NonNull;
+import androidx.appcompat.app.AlertDialog;
+import androidx.appcompat.widget.AppCompatEditText;
+import androidx.fragment.app.DialogFragment;
+import androidx.fragment.app.Fragment;
+import androidx.fragment.app.FragmentManager;
+import androidx.fragment.app.FragmentTransaction;
import com.android.deskclock.data.DataModel;
import com.android.deskclock.data.Timer;
diff --git a/src/com/android/deskclock/alarms/AlarmTimeClickHandler.java b/src/com/android/deskclock/alarms/AlarmTimeClickHandler.java
index 6c9464946..acc7ec03a 100644
--- a/src/com/android/deskclock/alarms/AlarmTimeClickHandler.java
+++ b/src/com/android/deskclock/alarms/AlarmTimeClickHandler.java
@@ -16,11 +16,11 @@
package com.android.deskclock.alarms;
-import android.app.Fragment;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import android.os.Vibrator;
+import androidx.fragment.app.Fragment;
import com.android.deskclock.AlarmClockFragment;
import com.android.deskclock.LabelDialogFragment;
@@ -182,7 +182,7 @@ public final class AlarmTimeClickHandler {
Events.sendAlarmEvent(R.string.action_set_label, R.string.label_deskclock);
final LabelDialogFragment fragment =
LabelDialogFragment.newInstance(alarm, alarm.label, mFragment.getTag());
- LabelDialogFragment.show(mFragment.getFragmentManager(), fragment);
+ LabelDialogFragment.show(mFragment.getParentFragmentManager(), fragment);
}
public void onTimeSet(int hourOfDay, int minute) {
diff --git a/src/com/android/deskclock/alarms/TimePickerDialogFragment.java b/src/com/android/deskclock/alarms/TimePickerDialogFragment.java
index 33fc757e3..05d962b06 100644
--- a/src/com/android/deskclock/alarms/TimePickerDialogFragment.java
+++ b/src/com/android/deskclock/alarms/TimePickerDialogFragment.java
@@ -17,16 +17,16 @@
package com.android.deskclock.alarms;
import android.app.Dialog;
-import android.app.DialogFragment;
-import android.app.Fragment;
-import android.app.FragmentManager;
import android.app.TimePickerDialog;
import android.content.Context;
import android.content.DialogInterface;
import android.os.Bundle;
-import androidx.appcompat.app.AlertDialog;
import android.text.format.DateFormat;
import android.widget.TimePicker;
+import androidx.appcompat.app.AlertDialog;
+import androidx.fragment.app.DialogFragment;
+import androidx.fragment.app.Fragment;
+import androidx.fragment.app.FragmentManager;
import com.android.deskclock.Utils;
diff --git a/src/com/android/deskclock/provider/Alarm.java b/src/com/android/deskclock/provider/Alarm.java
index fc8aebdb2..0d5a726f0 100644
--- a/src/com/android/deskclock/provider/Alarm.java
+++ b/src/com/android/deskclock/provider/Alarm.java
@@ -20,13 +20,13 @@ import android.content.ContentResolver;
import android.content.ContentUris;
import android.content.ContentValues;
import android.content.Context;
-import android.content.CursorLoader;
import android.content.Intent;
import android.database.Cursor;
import android.media.RingtoneManager;
import android.net.Uri;
import android.os.Parcel;
import android.os.Parcelable;
+import androidx.loader.content.CursorLoader;
import com.android.deskclock.R;
import com.android.deskclock.data.DataModel;
diff --git a/src/com/android/deskclock/timer/TimerFragment.java b/src/com/android/deskclock/timer/TimerFragment.java
index 8b301050b..afb6ac817 100644
--- a/src/com/android/deskclock/timer/TimerFragment.java
+++ b/src/com/android/deskclock/timer/TimerFragment.java
@@ -106,7 +106,7 @@ public final class TimerFragment extends DeskClockFragment {
Bundle savedInstanceState) {
final View view = inflater.inflate(R.layout.timer_fragment, container, false);
- mAdapter = new TimerPagerAdapter(getFragmentManager());
+ mAdapter = new TimerPagerAdapter(getParentFragmentManager());
mViewPager = (ViewPager) view.findViewById(R.id.vertical_view_pager);
mViewPager.setAdapter(mAdapter);
mViewPager.addOnPageChangeListener(mTimerPageChangeListener);
diff --git a/src/com/android/deskclock/timer/TimerItemFragment.java b/src/com/android/deskclock/timer/TimerItemFragment.java
index 7ce68765c..33b904285 100644
--- a/src/com/android/deskclock/timer/TimerItemFragment.java
+++ b/src/com/android/deskclock/timer/TimerItemFragment.java
@@ -16,12 +16,12 @@
package com.android.deskclock.timer;
-import android.app.Fragment;
import android.content.Context;
import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
+import androidx.fragment.app.Fragment;
import com.android.deskclock.LabelDialogFragment;
import com.android.deskclock.R;
diff --git a/src/com/android/deskclock/timer/TimerPagerAdapter.java b/src/com/android/deskclock/timer/TimerPagerAdapter.java
index 224d71d16..8b258942c 100644
--- a/src/com/android/deskclock/timer/TimerPagerAdapter.java
+++ b/src/com/android/deskclock/timer/TimerPagerAdapter.java
@@ -17,14 +17,14 @@
package com.android.deskclock.timer;
import android.annotation.SuppressLint;
-import android.app.Fragment;
-import android.app.FragmentManager;
-import android.app.FragmentTransaction;
-import androidx.legacy.app.FragmentCompat;
-import androidx.viewpager.widget.PagerAdapter;
import android.util.ArrayMap;
import android.view.View;
import android.view.ViewGroup;
+import androidx.fragment.app.Fragment;
+import androidx.fragment.app.FragmentManager;
+import androidx.fragment.app.FragmentTransaction;
+import androidx.legacy.app.FragmentCompat;
+import androidx.viewpager.widget.PagerAdapter;
import com.android.deskclock.data.DataModel;
import com.android.deskclock.data.Timer;
@@ -182,7 +182,7 @@ class TimerPagerAdapter extends PagerAdapter implements TimerListener {
}
private static void setItemVisible(Fragment item, boolean visible) {
- FragmentCompat.setMenuVisibility(item, visible);
- FragmentCompat.setUserVisibleHint(item, visible);
+ item.setMenuVisibility(visible);
+ item.setUserVisibleHint(visible);
}
} \ No newline at end of file