diff options
author | Colin Marsch <colinmarsch@google.com> | 2020-08-17 17:32:57 -0500 |
---|---|---|
committer | Michael Bestas <mkbestas@lineageos.org> | 2020-12-08 19:39:11 +0200 |
commit | 0cbc389d4a58361534a6a548d67c6de5dcf63ecd (patch) | |
tree | 47b4999fdae61d1bbd6f7b5bffd1d2e8e01a944c | |
parent | c6da36afffb5a683e4ed14b66147822b6737efb7 (diff) |
AOSP/DeskClock - Fix deprecated calls: ScreensaverSettings,SettingsActivity
Test: manual, tested the DeskClock UI. As well tests were ran as follows
$ source build/envsetup.sh
$ lunch aosp_sargo-userdebug
$ make DeskClock
$ adb install out/target/product/sargo/product/app/DeskClock/DeskClock.apk
$ atest DeskClockTests
$ make DeskClockJava
$ adb install out/target/product/sargo/product/app/DeskClockJava/DeskClockJava.apk
$ atest DeskClockTests
BUG: 157255731
Change-Id: Iecbbe5b390e8121bd6131431b2fd2f2c56467428
-rw-r--r-- | src/com/android/deskclock/settings/ScreensaverSettingsActivity.java | 14 | ||||
-rw-r--r-- | src/com/android/deskclock/settings/SettingsActivity.java | 5 |
2 files changed, 12 insertions, 7 deletions
diff --git a/src/com/android/deskclock/settings/ScreensaverSettingsActivity.java b/src/com/android/deskclock/settings/ScreensaverSettingsActivity.java index edc055469..55587f687 100644 --- a/src/com/android/deskclock/settings/ScreensaverSettingsActivity.java +++ b/src/com/android/deskclock/settings/ScreensaverSettingsActivity.java @@ -19,11 +19,11 @@ package com.android.deskclock.settings; import android.annotation.TargetApi; import android.os.Build; import android.os.Bundle; -import android.preference.ListPreference; -import android.preference.Preference; -import android.preference.PreferenceFragment; -import androidx.appcompat.app.AppCompatActivity; import android.view.MenuItem; +import androidx.appcompat.app.AppCompatActivity; +import androidx.preference.ListPreference; +import androidx.preference.Preference; +import androidx.preference.PreferenceFragmentCompat; import com.android.deskclock.R; import com.android.deskclock.Utils; @@ -55,7 +55,7 @@ public final class ScreensaverSettingsActivity extends AppCompatActivity { } - public static class PrefsFragment extends PreferenceFragment + public static class PrefsFragment extends PreferenceFragmentCompat implements Preference.OnPreferenceChangeListener { @Override @@ -66,6 +66,10 @@ public final class ScreensaverSettingsActivity extends AppCompatActivity { if (Utils.isNOrLater()) { getPreferenceManager().setStorageDeviceProtected(); } + } + + @Override + public void onCreatePreferences(Bundle savedInstanceState, String rootKey) { addPreferencesFromResource(R.xml.screensaver_settings); } diff --git a/src/com/android/deskclock/settings/SettingsActivity.java b/src/com/android/deskclock/settings/SettingsActivity.java index dcb570758..074771fff 100644 --- a/src/com/android/deskclock/settings/SettingsActivity.java +++ b/src/com/android/deskclock/settings/SettingsActivity.java @@ -235,7 +235,8 @@ public final class SettingsActivity extends BaseActivity { private void showDialog(PreferenceDialogFragmentCompat fragment) { // Don't show dialog if one is already shown. - if (getFragmentManager().findFragmentByTag(PREFERENCE_DIALOG_FRAGMENT_TAG) != null) { + if (getParentFragmentManager() + .findFragmentByTag(PREFERENCE_DIALOG_FRAGMENT_TAG) != null) { return; } // Always set the target fragment, this is required by PreferenceDialogFragment @@ -243,7 +244,7 @@ public final class SettingsActivity extends BaseActivity { fragment.setTargetFragment(this, 0); // Don't use getChildFragmentManager(), it causes issues on older platforms when the // target fragment is being restored after an orientation change. - fragment.show(getFragmentManager(), PREFERENCE_DIALOG_FRAGMENT_TAG); + fragment.show(getParentFragmentManager(), PREFERENCE_DIALOG_FRAGMENT_TAG); } /** |