summaryrefslogtreecommitdiff
path: root/tools/integrate/PushAndroidCode.java
diff options
context:
space:
mode:
authorAndy McFadden <fadden@android.com>2010-04-22 17:08:11 -0700
committerAndy McFadden <fadden@android.com>2010-04-23 10:34:36 -0700
commit2ecec21f339fc6712eb8a65b85822df6b2947977 (patch)
tree1881bb09ce9144a2100b1d471fd10730233ed753 /tools/integrate/PushAndroidCode.java
parentcb109d3b97fb1f67b2e941ca22813986b6de97e0 (diff)
Fix a deadlock in the breakpoint code.
In froyo we started using "hard" breakpoints, where we replace the existing opcodes with breakpoint instructions. This requires some coordination to avoid confusing the verifier. The previous approach allowed the breakpoints to be inserted, and "undid" them while the verifier ran; this worked, but caused us to be holding a lock for an extended period. The new approach just avoids altering the bytecode of unverified classes, and then "flushes" the breakpoint set out between the time when verification completes and class initialization starts. This removes the possibility of blocking with the lock held, and makes everything much simpler. For bug 2615063. Change-Id: I7f43e09a755fba27b335454659b3f04e8b2179ac
Diffstat (limited to 'tools/integrate/PushAndroidCode.java')
0 files changed, 0 insertions, 0 deletions