summaryrefslogtreecommitdiff
path: root/test-rules
diff options
context:
space:
mode:
authorAndrei Onea <andreionea@google.com>2019-10-15 18:00:15 +0100
committerAndrei Onea <andreionea@google.com>2019-10-16 16:19:14 +0100
commite7357d67828a4fef220698b85d09920b44f0a635 (patch)
treedc955e4551ebb9063e40013488e45fe8077d141c /test-rules
parent435437f4e9ff2becab7b539dd98c7cee53dc4816 (diff)
Remove redundant checks in CompatChangeRule
Checking for overlap between enabled and disabled changes is redundant, as the check occurs already in the Compatibility.ChangeConfig constructor. Bug: 140367850 Test: http://aosp/1113771 Change-Id: I87526076a58bd33e733eb2bfff95d33822fffc87
Diffstat (limited to 'test-rules')
-rw-r--r--test-rules/src/platform_compat/java/android/compat/CompatChangeRule.java13
1 files changed, 4 insertions, 9 deletions
diff --git a/test-rules/src/platform_compat/java/android/compat/CompatChangeRule.java b/test-rules/src/platform_compat/java/android/compat/CompatChangeRule.java
index 2586f9c9e2..1bae1a2c31 100644
--- a/test-rules/src/platform_compat/java/android/compat/CompatChangeRule.java
+++ b/test-rules/src/platform_compat/java/android/compat/CompatChangeRule.java
@@ -86,17 +86,12 @@ public class CompatChangeRule implements TestRule {
if (disableCompatChanges != null) {
disabled.addAll(Longs.asList(disableCompatChanges.value()));
}
- ArraySet<Long> intersection = new ArraySet<>(enabled);
- intersection.retainAll(disabled);
- if (!intersection.isEmpty()) {
- throw new IllegalArgumentException(
- "Changes " + intersection + " are both enabled and disabled.");
- }
- if (enabled.isEmpty() && disabled.isEmpty()) {
- throw new IllegalStateException("Added a CompatChangeRule without specifying any "
+ ChangeConfig config = new ChangeConfig(enabled, disabled);
+ if (config.isEmpty()) {
+ throw new IllegalArgumentException("Added a CompatChangeRule without specifying any "
+ "@EnableCompatChanges or @DisableCompatChanges !");
}
- return new CompatChangeStatement(statement, new ChangeConfig(enabled, disabled));
+ return new CompatChangeStatement(statement, config);
}
private static class CompatChangeStatement extends Statement {