diff options
author | Przemyslaw Szczepaniak <pszczepaniak@google.com> | 2016-03-15 09:42:19 +0000 |
---|---|---|
committer | Przemyslaw Szczepaniak <pszczepaniak@google.com> | 2016-03-15 09:42:19 +0000 |
commit | ed4f365789d43b1961657195df223a19bf4ef20f (patch) | |
tree | 214d4e0cdccf19471194d03dd3172933336910f1 /jsr166-tests/src/test/java/jsr166/AtomicLongFieldUpdaterTest.java | |
parent | 5328e07d282bef36ac8b757bbee16a761415b2c4 (diff) |
Revert "JSR-166 update"
I missed comments on framework/base change regarding "@since 9" parts
This reverts commit 5328e07d282bef36ac8b757bbee16a761415b2c4.
Change-Id: Iff71b8a17e79a0a5c1ecadc05bccadceabb83393
Diffstat (limited to 'jsr166-tests/src/test/java/jsr166/AtomicLongFieldUpdaterTest.java')
-rw-r--r-- | jsr166-tests/src/test/java/jsr166/AtomicLongFieldUpdaterTest.java | 107 |
1 files changed, 3 insertions, 104 deletions
diff --git a/jsr166-tests/src/test/java/jsr166/AtomicLongFieldUpdaterTest.java b/jsr166-tests/src/test/java/jsr166/AtomicLongFieldUpdaterTest.java index d46280b889..204f814fab 100644 --- a/jsr166-tests/src/test/java/jsr166/AtomicLongFieldUpdaterTest.java +++ b/jsr166-tests/src/test/java/jsr166/AtomicLongFieldUpdaterTest.java @@ -15,10 +15,9 @@ import junit.framework.TestSuite; public class AtomicLongFieldUpdaterTest extends JSR166TestCase { volatile long x = 0; - protected volatile long protectedField; - private volatile long privateField; + int z; long w; - float z; + // android-note: Removed because the CTS runner does a bad job of // retrying tests that have suite() declarations. // @@ -26,59 +25,7 @@ public class AtomicLongFieldUpdaterTest extends JSR166TestCase { // main(suite(), args); // } // public static Test suite() { - // return new TestSuite(AtomicLongFieldUpdaterTest.class); - // } - - // for testing subclass access - // android-note: Removed because android doesn't restrict reflection access - // static class AtomicLongFieldUpdaterTestSubclass extends AtomicLongFieldUpdaterTest { - // public void checkPrivateAccess() { - // try { - // AtomicLongFieldUpdater<AtomicLongFieldUpdaterTest> a = - // AtomicLongFieldUpdater.newUpdater - // (AtomicLongFieldUpdaterTest.class, "privateField"); - // shouldThrow(); - // } catch (RuntimeException success) { - // assertNotNull(success.getCause()); - // } - // } - - // public void checkCompareAndSetProtectedSub() { - // AtomicLongFieldUpdater<AtomicLongFieldUpdaterTest> a = - // AtomicLongFieldUpdater.newUpdater - // (AtomicLongFieldUpdaterTest.class, "protectedField"); - // this.protectedField = 1; - // assertTrue(a.compareAndSet(this, 1, 2)); - // assertTrue(a.compareAndSet(this, 2, -4)); - // assertEquals(-4, a.get(this)); - // assertFalse(a.compareAndSet(this, -5, 7)); - // assertEquals(-4, a.get(this)); - // assertTrue(a.compareAndSet(this, -4, 7)); - // assertEquals(7, a.get(this)); - // } - // } - - // static class UnrelatedClass { - // public void checkPackageAccess(AtomicLongFieldUpdaterTest obj) { - // obj.x = 72L; - // AtomicLongFieldUpdater<AtomicLongFieldUpdaterTest> a = - // AtomicLongFieldUpdater.newUpdater - // (AtomicLongFieldUpdaterTest.class, "x"); - // assertEquals(72L, a.get(obj)); - // assertTrue(a.compareAndSet(obj, 72L, 73L)); - // assertEquals(73L, a.get(obj)); - // } - - // public void checkPrivateAccess(AtomicLongFieldUpdaterTest obj) { - // try { - // AtomicLongFieldUpdater<AtomicLongFieldUpdaterTest> a = - // AtomicLongFieldUpdater.newUpdater - // (AtomicLongFieldUpdaterTest.class, "privateField"); - // throw new AssertionError("should throw"); - // } catch (RuntimeException success) { - // assertNotNull(success.getCause()); - // } - // } + // return new TestSuite(...); // } AtomicLongFieldUpdater<AtomicLongFieldUpdaterTest> updaterFor(String fieldName) { @@ -119,26 +66,6 @@ public class AtomicLongFieldUpdaterTest extends JSR166TestCase { } /** - * construction using private field from subclass throws RuntimeException - */ - // android-note: Removed because android doesn't restrict reflection access - // public void testPrivateFieldInSubclass() { - // AtomicLongFieldUpdaterTestSubclass s = - // new AtomicLongFieldUpdaterTestSubclass(); - // s.checkPrivateAccess(); - // } - - /** - * construction from unrelated class; package access is allowed, - * private access is not - */ - // android-note: Removed because android doesn't restrict reflection access - // public void testUnrelatedClassAccess() { - // new UnrelatedClass().checkPackageAccess(this); - // new UnrelatedClass().checkPrivateAccess(this); - // } - - /** * get returns the last value set or assigned */ public void testGetSet() { @@ -183,34 +110,6 @@ public class AtomicLongFieldUpdaterTest extends JSR166TestCase { } /** - * compareAndSet succeeds in changing protected field value if - * equal to expected else fails - */ - public void testCompareAndSetProtected() { - AtomicLongFieldUpdater<AtomicLongFieldUpdaterTest> a; - a = updaterFor("protectedField"); - protectedField = 1; - assertTrue(a.compareAndSet(this, 1, 2)); - assertTrue(a.compareAndSet(this, 2, -4)); - assertEquals(-4, a.get(this)); - assertFalse(a.compareAndSet(this, -5, 7)); - assertEquals(-4, a.get(this)); - assertTrue(a.compareAndSet(this, -4, 7)); - assertEquals(7, a.get(this)); - } - - /** - * compareAndSet succeeds in changing protected field value if - * equal to expected else fails - */ - // android-note: Removed because android doesn't restrict reflection access - // public void testCompareAndSetProtectedInSubclass() { - // AtomicLongFieldUpdaterTestSubclass s = - // new AtomicLongFieldUpdaterTestSubclass(); - // s.checkCompareAndSetProtectedSub(); - // } - - /** * compareAndSet in one thread enables another waiting for value * to succeed */ |