diff options
| author | Tobias Thierer <tobiast@google.com> | 2016-06-15 14:09:01 +0100 |
|---|---|---|
| committer | Tobias Thierer <tobiast@google.com> | 2016-06-23 10:25:48 +0100 |
| commit | cc4ece7f7ff42e955ac454aed51fc1a8e38abe4c (patch) | |
| tree | c1e727b30246d8c2e9e3ffe9f0acd1c8306eba99 /include/ScopedJavaUnicodeString.h | |
| parent | 5d43f66806781a88baaee8a8e9406f7d328616ef (diff) | |
URLConnectionTest: explicitly close() all the TestSSLContexts
This fixes the test failing from the un-close()d TestSSLContexts
when run on vogar. It doesn't disconnect Http{,s}URLConnections
which the test constructs; these can cause the test to fail
similarly.
The un-close()d contexts caused the test to fail in this manner:
- TestSSLContext.serverSocket.getImpl() instanceof SocksSocketImpl
which extends AbstractPlainSocketImpl.
- That base class in turn uses CloseGuard to enforce (best effort)
that close() is being called.
I originally observed this in vogar on a local branch with an
updated version of OkHttp (2.7.5). I have reproduced it on
AOSP master head but have not reproduced it under cts-tradefed.
Therefore I conclude that there is an additional bug that caused
this test to pass in cts-tradefed when it should have failed; I
have filed bug 29533469 for that.
Change-Id: Ifffeb576b25e07375917dcfc0fdec3c6a9da1be9
Diffstat (limited to 'include/ScopedJavaUnicodeString.h')
0 files changed, 0 insertions, 0 deletions
