summaryrefslogtreecommitdiff
path: root/include/ScopedJavaUnicodeString.h
diff options
context:
space:
mode:
authorTobias Thierer <tobiast@google.com>2018-06-24 21:29:57 +0100
committerTobias Thierer <tobiast@google.com>2018-06-27 14:45:46 +0100
commitc24c1b83b736433564ba25edc56992c497d87343 (patch)
treecb1f685bb68190e073e4d9fbbcc7bc1968e7bea7 /include/ScopedJavaUnicodeString.h
parent2cef2fdd535d6636f76c54cb870b02b0e5a93e0d (diff)
Verify java.util.Locale against upstream OpenJDK8u121-b13, step 1.
This CL contains comment/documentation changes only; behavior is unchanged. - Tweak change markers - Use the terminology "Use ICU." more consistently. - Add missing change summaries, eg. to END markers. - ... - In most cases, add the commented-out upstream code whose logic has been rewritten on top of ICU. - The behavior of Android's re-written (on top of ICU) logic was not analyzed in detail as part of this CL. Upstream's getDisplay{Language,Script}(Locale) delegate to getDisplayString() but getDisplay{Name,Variant}(Locale) do not. Presumably upstream delegates only because their implementations happen to besimilar, but they are not as similar on Android. Therefore Android continues to not delegate - this code is not touched as part of this CL. However, this CL adds a unit test to ensure that all four methods continue to throw NPE when given a null argument on a Locale instance whose corresponding code value is not "". Android also carries a patch to make the documentation of three out of those four methods shorter and carry weaker guarantees around fall-backs and precise behavior; it's not known why this change was made in Android, but it carries the advantage of not specifying behavior that we might want to change later, or may already have changed (through our reimplementation on top of ICU). Therefore this CL does not touch that documentation. Bug: 35910877 Test: Treehugger Test: LocaleTest Change-Id: Ib66c21f422e991d7d034d93b882ec4130f0f58fc
Diffstat (limited to 'include/ScopedJavaUnicodeString.h')
0 files changed, 0 insertions, 0 deletions