summaryrefslogtreecommitdiff
path: root/annotations/generate_annotated_java_files.py
diff options
context:
space:
mode:
authorTobias Thierer <tobiast@google.com>2018-04-26 10:56:57 +0100
committerTobias Thierer <tobiast@google.com>2018-05-01 12:25:46 +0100
commitfe0dd064007e3ffb3a6ccdd8f31fd1e2f85b165f (patch)
treef8db8da0cd8342c64b21f2c6fdcc786efc12723d /annotations/generate_annotated_java_files.py
parent2e6efcfa6e66c10130eba37a31dfa5044170fe14 (diff)
Verify java.nio.ByteBuffer against OpenJDK8u121-b13, part 3.
This completes verification of ByteBuffer. After this CL, all remaining Android changes carry appropriate change markers. 1. Document addition of ByteBuffer.{get,put}*Unchecked() and make these methods abstract. These methods are implemented in DirectByteBuffer and HeapByteBuffer. There is no need for the abstract base class to carry an implemetation that throws UnsupportedOperationException. It would be possible to move these methods out into a separate interface (implemented by DirectByteBuffer or another utility class instace passed separately into the *BufferAs*Buffer constructors) to keep these changes out of ByteBuffer.java. It's not clear whether this is worth the effort overall, so this CL does not do that. 2. Document addition of boolean isAccessible(), void setAccessible(boolean). It would have been possible to have these methods only on DirectByteBuffer; callers of setAccessible() would have needed to use the compile-time type DirectByteBuffer where they currently use ByteBuffer and rely on the fact that that method won't throw only at runtime. The size of this refactoring in MediaCodec (and perhaps elsewhere) didn't seem worth it, so this CL does not pursue that option. Test: CtsLibcoreTestCases Bug: 35910877 Change-Id: I507e2ce605fb52ab915fd26b48aa34bbaca1fb45
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions