diff options
author | Tobias Thierer <tobiast@google.com> | 2017-08-25 13:47:36 +0100 |
---|---|---|
committer | Tobias Thierer <tobiast@google.com> | 2017-08-29 19:53:06 +0100 |
commit | f1866bd83f2c05e3e0bd52ed40296edf2599f28e (patch) | |
tree | bd95ba1a8751a6d7b7662bdf353020680971e4b9 /annotations/generate_annotated_java_files.py | |
parent | 7cd7bf2e543625280ac22d7b2a18ffa3e3cbbe44 (diff) |
Attempt to de-flake ServerSocketConcurrentCloseTest
Relax non-critical assertion that sometimes fails on
old devices and for which investigation has not revealed
any serious underlying cause.
The test is running 100 iterations; during each iteration,
separate server and client threads repeatedly connect to
each other, until they're shut down after 50msec.
On some systems, the test runs out of sockets/connections
since they're still stuck in TIMED_WAIT state, leading
to later iterations failing to achieve any connections.
The test had an assertion that connections were achieved
in *each* iteration, and that assertion would fail on such
systems.
Since the assertion was only ever intended to guard in a
bug in the test, rather than a bug in the code under test,
this CL relaxes that assertion to only assert that *some*
(currently >= 5) out of the 100 iterations achieve any
connections.
The main purpose of the test, ensuring that the server
thread does not block indefinitely when the ServerSocket
is closed, is unaffected.
Bug: 65024353
Test: ran ServerSocketConcurrentCloseTest once (on Pixel XL).
(cherry picked from commit 1cbfa9d8393e3ce68706a3d221462afe69db7f97)
Change-Id: I8c11954bc6374850fcb2962a352fa7683de48308
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions