diff options
author | Neil Fuller <nfuller@google.com> | 2016-06-29 14:15:59 +0100 |
---|---|---|
committer | Neil Fuller <nfuller@google.com> | 2016-06-30 13:52:03 +0100 |
commit | e2137568dafbbb450c539d0f04f1618b485343c4 (patch) | |
tree | 26214a2dd004697feec47296ef51fa1eb48dafd6 /annotations/generate_annotated_java_files.py | |
parent | 22bfef3e51bb2b39c870465775a0d32b46d6ebe8 (diff) |
Remove a race hazard from the execrable Support_TestWebServer
Use of this class was resulting in threads being left in a
spinning state due to the accept socket being closed but
"running" still being true: the exception thrown from
Socket.accept() was being swallowed.
This is likely because there is a race between the thread
actually starting (i.e. run() actually executing)
and, in short-lived tests, the server being shutdown:
if AcceptThread.close() was called before AcceptThread.run()
then when run() actually executed it would loop forever.
Some dead code has been removed.
Test: Ran the CTS tests
Bug: 29820565
Bug: 29365528
(cherry picked from commit 5558171bce9b70743bed9f6d3543d2eb15d51bb0)
Change-Id: I895ecbd171c9495ddda85de740519ba1b2c51d62
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions