diff options
| author | Tobias Thierer <tobiast@google.com> | 2019-05-22 13:57:55 +0100 |
|---|---|---|
| committer | Tobias Thierer <tobiast@google.com> | 2019-05-22 16:05:43 +0100 |
| commit | ca12b524cf825de081d89a9a8fa6626d824cf319 (patch) | |
| tree | ad5ccaf2951abc2a7d16d95740e690791c7c7646 /annotations/generate_annotated_java_files.py | |
| parent | b17d891dd3427363f31a8953dd462647dda6a018 (diff) | |
XmlPullParser docs: getColumnNumber() is 1-based.
All docs that I could find claim that it is 0-based, but:
* The implementation is 1-based.
* xmlpull.org appears unmaintained since ~ 2004 and has no update.
* PullParserTest (and thus its implementation KxmlPullParserTest)
enforces 1-based counting.
* getLineNumber()'s documentation and implementation is also 1-based.
On balance, this suggests that the documentation around this method
being 0-based is wrong. This CL fixes it.
Note that the documentation also contains a statement about cases
where the methods return -1, but the implementation doesn't seem
to ever return a value < 1. The case of -1 also doesn't seem to be
covered by tests. This CL does not touch that part of the documentation.
Fixes: 133248153
Test: atest CtsLibcoreTestCases:libcore.xml.KxmlPullParserTest
Change-Id: I8a15cd6686083552c3e52434966a4f56a2d9a87b
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions
