diff options
| author | Paul Duffin <paulduffin@google.com> | 2016-09-15 14:59:48 +0100 |
|---|---|---|
| committer | Paul Duffin <paulduffin@google.com> | 2016-09-16 15:42:33 +0100 |
| commit | be62aa290928ed1d1717398f6a9697386363c251 (patch) | |
| tree | 6e4d6e584ebad06f3a8edb7e298f234cdd9d5c0c /annotations/generate_annotated_java_files.py | |
| parent | ecd49d26dc5c4d9b8c7db11b7af0349da15eb946 (diff) | |
Fix TryFailThrowable warnings found by error prone
Errorprone has found various cases where Error is being
caught incorrectly, thereby incorrectly hiding actually
failing assertions. e.g.
try {
expectedToThrowError();
fail("Error not thrown");
} catch (Error expected) {}
This commit fixes the code and addresses the Errorprone
warnings. See http://errorprone.info/bugpattern/TryFailThrowable
for more details.
The fix to the ResourceLeakageDetectorTest test
method testDetectsUnclosedCloseGuard revealed that the test did
not previously work in CTS. The test has been disabled in this
change to remove the error prone warning. A more permanent fix
for this test will be provided under bug 31542223.
Bug: 31507496
Test: Ran the tests using Vogar and CTS
Change-Id: Ic7d72b801299d654eacd0f037cd8d12d2cd8f7bc
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions