summaryrefslogtreecommitdiff
path: root/annotations/generate_annotated_java_files.py
diff options
context:
space:
mode:
authorPete Gillin <peteg@google.com>2018-03-29 12:19:24 +0100
committerPete Gillin <peteg@google.com>2018-04-06 13:39:32 +0100
commit8c32690a8e6f7d31e0d9fe5bb1cd69ed93444208 (patch)
tree8c10568b0189b404bc354e05954e5240eddf61c3 /annotations/generate_annotated_java_files.py
parentcdfe551da6e9a5b6a02bd5a27d622901e9170367 (diff)
Verify j.u.logging.LogManager against OpenJDK 8u121-b13.
There are two minor code changes in here: 1. The (Android-added) getClassInstance method, which implements the fallback from the system classloader to the context classloader, is simplified: a. If the call on the context classloader fails, it throws ClassNotFoundException instead of returning null. Every single caller assumed the return was non-null, so you'd have got a NullPointerException, and a ClassNotFoundException seems more useful. Also, this means that the behaviour is now identical to upstream's in the two of the six cases where upstream was already doing the fallback, and closer to upstream's in the other four. b. The null-check on its argument is removed. None of the callers will ever pass in null, and as noted above the behaviour of returning null is useless. 2. The changes in http://r.android.com/197098 are effectively reverted. That android-N-era change fixed some failing CTS tests. I'm unable to reproduce the failure with this change, so I think the patch is no longer needed. Test: cts-tradefed run cts -m CtsLibcoreTestCases -t com.android.org.apache.harmony.logging.tests.java.util.logging Bug: 35910877 Change-Id: I91d6d1924a0acac7192fcd5c7d533053a834a0a8
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions