diff options
| author | gcollins <gcollins@antennasoftware.com> | 2012-06-04 17:26:45 -0400 |
|---|---|---|
| committer | gcollins <gareth.o.collins@gmail.com> | 2012-07-13 14:54:57 -0400 |
| commit | 7c935d4e4ca990334200cf5eb4fbcfac718c6b45 (patch) | |
| tree | 0ac5c997baf6fa83bf6c0df3859421c6551e5c5d /annotations/generate_annotated_java_files.py | |
| parent | 9c915757002d6a47093e849e0402538a6aa1b483 (diff) | |
CertificateRequest should handle case where certificate is requested but none is available.
Android SSL client was not handling a CertificateRequest where there was no cert to send.
It had a problem because it was assuming that if the CertificateMessage response is not null,
it means there is a cert included, which is not true (if it has no cert to send an empty CertificateMessage
is sent to the server). So I updated the CertificateVerify creation check to also check whether the CertificateMessage
contained any certs (ClientHandshakeImpl.java).
In testing I found that the same error was in the server code so I made the same change there
(ServerHandshakeImpl.java).
I added two test cases to SSLEngineTest - one to directly test the scenario (test_SSLEngine_clientAuthWantedNoClientCert)
and one to just double-check that the server would not allow the connection if setNeedClientAuth (test_SSLEngine_clientAuthNeededNoClientCert).
Bug: http://code.google.com/p/android/issues/detail?id=31903
Change-Id: Ideb57d6ccbcdd54ca24dc3063e60aba2653c8414
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions