diff options
| author | Tobias Thierer <tobiast@google.com> | 2017-04-24 18:05:48 +0100 |
|---|---|---|
| committer | Tobias Thierer <tobiast@google.com> | 2017-04-25 16:23:06 +0100 |
| commit | 5b8e053c8d0b8c4ecc24af65b43e9c1a0ea170d8 (patch) | |
| tree | 1847dc04b39f6f3eb0b45ad18ebb0146dba99cff /annotations/generate_annotated_java_files.py | |
| parent | 9a7ad8556e4f5530217a08cee95e1cd32c186bbd (diff) | |
Fix PrintStream ctor ignoring Charset parameter.
Libcore commit de626ec8a109ea18283d96c720cc57e2f32f67fa
changed PrintStream's fields charOut and textOut to be
lazily initialized from a (new) field charset, but
forgot to initialize that field in the constructor.
That lead to PrintStream always using the system default
encoding (UTF-8 on Android) when writing character data,
rather than the specified charset.
This CL fixes the PrintStream constructor to initialize
the charset field. It also tweaks the Android-changed
comments, and adds tests for the previously buggy ctor.
Since the original CL didn't specify a reason, it's not
clear why the change was made. It may be possible to
revert the entire change in future, or to contribute it
back to upstream.
Bug: 37313782
Test: PrintStreamTest
Change-Id: I80f9bc4e5a6f0b84867e402930dd517062169342
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions