diff options
| author | Jesse Wilson <jessewilson@google.com> | 2011-09-12 19:04:26 -0400 |
|---|---|---|
| committer | Jesse Wilson <jessewilson@google.com> | 2011-09-12 19:08:14 -0400 |
| commit | 2ca11d6eae460f94bc42bc2e453fac93f4b94eb0 (patch) | |
| tree | 8b9a69981807234dac8e46b8ea80e26eb4ca713a /annotations/generate_annotated_java_files.py | |
| parent | 341667ceaa55a1f22c61aa49be82560d5dbe7929 (diff) | |
Discourage developers from catching subclasses of SocketException.
We recently had a bug in Apache HTTP client where catching a
specific exception subclass caused incorrect behavior. Apache HTTP
expects a ConnectException but we're throwing its superclass,
SocketException. Unfortunately I don't think fixing this to throw
ConnectException is any better; the best I can tell from the spec
this should be throwing a NoRouteToHostException which would still
fail on Apache HTTP client. I'm going to fix that code to catch the
appropriate type.
Bug: http://b/5293809
Bug: http://b/4411922
Change-Id: I189408f6e2355475510fb817c97017e7bae1739e
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions