summaryrefslogtreecommitdiff
path: root/annotations/generate_annotated_java_files.py
diff options
context:
space:
mode:
authorPaul Duffin <paulduffin@google.com>2019-10-10 18:15:01 +0100
committerPaul Duffin <paulduffin@google.com>2019-10-10 18:24:23 +0100
commit1d7d4a76d1fde9426b742fd0a702f4b1aca4de03 (patch)
treeac23a441b1869dd85a37c2b728d3832c562fe9b0 /annotations/generate_annotated_java_files.py
parent12b988ae6e601360de000f86761f9157100d2a47 (diff)
Fix build failure when OUT_DIR is outside ANDROID_BUILD_TOP
Caused by use of --patch-module=java.base=. where . means current directory, i.e. build top. When there are some sources outside the current directory, such as generated stubs source from external/icu, then it fails because sources outside are not patched in. Similar behavior is seen when OUT_DIR_COMMON_BASE is outside the top directory. Using patch_module: "java.base" causes Soong to add --patch-module=java.base=<paths to each source root> Which means that it works correctly irrespective of where the sources are. Using an OUT_DIR outside top does increase the length of command lines, presumably because it prevents paths being relativized against ANDROID_BUILD_TOP. So, using a short OUT_DIR path is required otherwise some targets fail with argument list too long errors. However, that issue is orthogonal to this and only mentioned because it came up during testing of this fix. Bug: 142397121 Test: OUT_DIR=<path-outside-top> m java Change-Id: Idb2826d58818cd33be8054418006bbbac513be5e
Diffstat (limited to 'annotations/generate_annotated_java_files.py')
0 files changed, 0 insertions, 0 deletions