diff options
| author | Pete Bentley <prb@google.com> | 2020-12-09 17:24:47 +0000 |
|---|---|---|
| committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2020-12-09 17:24:47 +0000 |
| commit | edd6100b745f5d766f54e23c29c5c7504e21a618 (patch) | |
| tree | ffb122974b94d98f1ac691558e2f07fe266005a1 | |
| parent | 428f80fe4f48587d2e362059f7eeb279def70117 (diff) | |
| parent | cad6f31431c6b6698db4f4e2a0da9fcfef67536a (diff) | |
Reject non-ASCII hostnames and SANs. am: 650e71cc3a am: cad6f31431
Original change: https://googleplex-android-review.googlesource.com/c/platform/libcore/+/13163680
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I06720828da12fd1aea7cfaa802a0794e51bc24d5
| -rw-r--r-- | harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java b/harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java index e6978385e0..96384adba2 100644 --- a/harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java +++ b/harmony-tests/src/test/java/org/apache/harmony/tests/javax/net/ssl/HostnameVerifierTest.java @@ -78,7 +78,7 @@ public class HostnameVerifierTest extends TestCase implements assertFalse(verifier.verify("a.foo.com", session)); assertTrue(verifier.verify("bar.com", session)); assertFalse(verifier.verify("a.bar.com", session)); - // The certificate has this name in the altnames section, but Conscrypt drops + // The certificate has this name in the altnames section, but OkHostnameVerifier drops // any altnames that are improperly encoded according to RFC 5280, which requires // non-ASCII characters to be encoded in ASCII via Punycode. assertFalse(verifier.verify("\u82b1\u5b50.co.jp", session)); @@ -129,11 +129,11 @@ public class HostnameVerifierTest extends TestCase implements assertFalse(verifier.verify("a.b.foo.com", session)); assertFalse(verifier.verify("bar.com", session)); assertTrue(verifier.verify("www.bar.com", session)); - assertTrue(verifier.verify("\u82b1\u5b50.bar.com", session)); assertFalse(verifier.verify("a.b.bar.com", session)); - // The certificate has this name in the altnames section, but Conscrypt drops + // The certificate has this name in the altnames section, but OkHostnameVerifier drops // any altnames that are improperly encoded according to RFC 5280, which requires // non-ASCII characters to be encoded in ASCII via Punycode. + assertFalse(verifier.verify("\u82b1\u5b50.bar.com", session)); assertFalse(verifier.verify("\u82b1\u5b50.co.jp", session)); assertFalse(verifier.verify("a.\u82b1\u5b50.co.jp", session)); } |