summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSanjay Singh <sisanj@codeaurora.org>2020-12-08 18:20:14 +0530
committerGerrit - the friendly Code Review server <code-review@localhost>2020-12-13 22:26:14 -0800
commitc0681dd10927a429e58f9162d6a09f6446920c06 (patch)
tree78cdd88f6a0668de91cf3ca00cb281a8bf761c50
parent554e511aa2dfeb7d9f107494ba76770a53cd91fc (diff)
mm-video-v4l2: venc: Close and delete handle on error
Close and delete handle when memory allocation fails, otherwise this may cause memory leak. Change-Id: Ie560b4af6b729d1cbcf0050c6d0c6ad6cbbcc817
-rw-r--r--mm-video-v4l2/vidc/venc/src/omx_video_base.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/mm-video-v4l2/vidc/venc/src/omx_video_base.cpp b/mm-video-v4l2/vidc/venc/src/omx_video_base.cpp
index 5c6c8db9..67fbff3c 100644
--- a/mm-video-v4l2/vidc/venc/src/omx_video_base.cpp
+++ b/mm-video-v4l2/vidc/venc/src/omx_video_base.cpp
@@ -3696,6 +3696,8 @@ OMX_ERRORTYPE omx_video::allocate_output_buffer(
m_pOutput_pmem[i].buffer = malloc(sizeof(output_metabuffer));
if (m_pOutput_pmem[i].buffer == NULL) {
DEBUG_PRINT_ERROR("%s: Failed to allocate meta buffer", __func__);
+ native_handle_close(handle);
+ native_handle_delete(handle);
return OMX_ErrorInsufficientResources;
}
(*bufferHdr)->nAllocLen = sizeof(output_metabuffer);