summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHoss Zhou <zhouh@codeaurora.org>2021-04-07 12:09:09 +0800
committerGerrit - the friendly Code Review server <code-review@localhost>2021-05-25 07:09:16 -0700
commitde95e878b63dcf5f2367d895913d9adbfddef94b (patch)
treefdd51918394af68767fd98c4092fb105e6746f90
parentef4d800a54f45b465bebece6f7e6c4492c7423c6 (diff)
fix ntrip parameters invalid issue
Ntrip parameters are variables stored in stack, their values may change after stack freed. Should not use reference. Change-Id: If13b859076e1feee444a9e6b8f54960d532c90b6 CRs-Fixed: 2918128
-rw-r--r--gnss/GnssAdapter.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/gnss/GnssAdapter.cpp b/gnss/GnssAdapter.cpp
index cff0298..6312f9b 100644
--- a/gnss/GnssAdapter.cpp
+++ b/gnss/GnssAdapter.cpp
@@ -6768,10 +6768,15 @@ void GnssAdapter::enablePPENtripStreamCommand(const GnssNtripConnectionParams& p
bool enableRTKEngine) {
(void)enableRTKEngine; //future parameter, not used
+ if (0 == params.size || params.hostNameOrIp.empty() || params.mountPoint.empty() ||
+ params.username.empty() || params.password.empty()) {
+ LOC_LOGe("Ntrip parameters are invalid!");
+ return;
+ }
struct enableNtripMsg : public LocMsg {
GnssAdapter& mAdapter;
- const GnssNtripConnectionParams& mParams;
+ const GnssNtripConnectionParams mParams;
inline enableNtripMsg(GnssAdapter& adapter,
const GnssNtripConnectionParams& params) :