1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
|
/*
* Copyright (C) 2019 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "EvsDisplay.h"
#include <ui/GraphicBufferAllocator.h>
#include <ui/GraphicBufferMapper.h>
using ::android::frameworks::automotive::display::V1_0::HwDisplayConfig;
using ::android::frameworks::automotive::display::V1_0::HwDisplayState;
using ::android::frameworks::automotive::display::V1_0::IAutomotiveDisplayProxyService;
using ::android::hardware::automotive::evs::V1_0::DisplayDesc;
using ::android::hardware::automotive::evs::V1_0::DisplayState;
using ::android::hardware::automotive::evs::V1_0::EvsResult;
namespace {
// Arbitrary magic number for self-recognition
constexpr uint32_t kDefaultDisplayBufferId = 0x3870;
} // namespace
namespace android::hardware::automotive::evs::V1_1::implementation {
EvsDisplay::EvsDisplay() {
EvsDisplay(nullptr, 0);
}
EvsDisplay::EvsDisplay(sp<IAutomotiveDisplayProxyService> pDisplayProxy, uint64_t displayId)
: mDisplayProxy(pDisplayProxy),
mDisplayId(displayId),
mGlWrapper(std::make_unique<GlWrapper>()) {
ALOGD("EvsDisplay instantiated");
// Set up our self description
// NOTE: These are arbitrary values chosen for testing
mInfo.displayId = "Mock Display";
mInfo.vendorFlags = 3870;
// Assemble the buffer description we'll use for our render target
mBuffer.width = 640;
mBuffer.height = 360;
mBuffer.format = HAL_PIXEL_FORMAT_RGBA_8888;
mBuffer.usage = GRALLOC_USAGE_HW_RENDER | GRALLOC_USAGE_HW_COMPOSER;
mBuffer.bufferId = kDefaultDisplayBufferId;
mBuffer.pixelSize = 4;
}
EvsDisplay::~EvsDisplay() {
ALOGD("EvsDisplay being destroyed");
forceShutdown();
}
/**
* This gets called if another caller "steals" ownership of the display
*/
void EvsDisplay::forceShutdown() {
ALOGD("EvsDisplay forceShutdown");
std::lock_guard<std::mutex> lock(mAccessLock);
// If the buffer isn't being held by a remote client, release it now as an
// optimization to release the resources more quickly than the destructor might
// get called.
if (mBuffer.memHandle) {
// Report if we're going away while a buffer is outstanding
if (mFrameBusy) {
ALOGE("EvsDisplay going down while client is holding a buffer");
}
// Drop the graphics buffer we've been using
GraphicBufferAllocator& alloc(GraphicBufferAllocator::get());
alloc.free(mBuffer.memHandle);
mBuffer.memHandle = nullptr;
if (mGlWrapper) {
mGlWrapper->hideWindow(mDisplayProxy, mDisplayId);
mGlWrapper->shutdown();
}
}
// Put this object into an unrecoverable error state since somebody else
// is going to own the display now.
mRequestedState = DisplayState::DEAD;
}
/**
* Returns basic information about the EVS display provided by the system.
* See the description of the DisplayDesc structure for details.
*/
Return<void> EvsDisplay::getDisplayInfo(getDisplayInfo_cb _hidl_cb) {
ALOGD("getDisplayInfo");
// Send back our self description
_hidl_cb(mInfo);
return {};
}
/**
* Clients may set the display state to express their desired state.
* The HAL implementation must gracefully accept a request for any state
* while in any other state, although the response may be to ignore the request.
* The display is defined to start in the NOT_VISIBLE state upon initialization.
* The client is then expected to request the VISIBLE_ON_NEXT_FRAME state, and
* then begin providing video. When the display is no longer required, the client
* is expected to request the NOT_VISIBLE state after passing the last video frame.
*/
Return<EvsResult> EvsDisplay::setDisplayState(DisplayState state) {
ALOGD("setDisplayState");
std::lock_guard<std::mutex> lock(mAccessLock);
if (mRequestedState == DisplayState::DEAD) {
// This object no longer owns the display -- it's been superceeded!
return EvsResult::OWNERSHIP_LOST;
}
// Ensure we recognize the requested state so we don't go off the rails
if (state >= DisplayState::NUM_STATES) {
return EvsResult::INVALID_ARG;
}
if (!mGlWrapper) {
switch (state) {
case DisplayState::NOT_VISIBLE:
mGlWrapper->hideWindow(mDisplayProxy, mDisplayId);
break;
case DisplayState::VISIBLE:
mGlWrapper->showWindow(mDisplayProxy, mDisplayId);
break;
default:
break;
}
}
// Record the requested state
mRequestedState = state;
return EvsResult::OK;
}
/**
* The HAL implementation should report the actual current state, which might
* transiently differ from the most recently requested state. Note, however, that
* the logic responsible for changing display states should generally live above
* the device layer, making it undesirable for the HAL implementation to
* spontaneously change display states.
*/
Return<DisplayState> EvsDisplay::getDisplayState() {
ALOGD("getDisplayState");
std::lock_guard<std::mutex> lock(mAccessLock);
return mRequestedState;
}
/**
* This call returns a handle to a frame buffer associated with the display.
* This buffer may be locked and written to by software and/or GL. This buffer
* must be returned via a call to returnTargetBufferForDisplay() even if the
* display is no longer visible.
*/
// TODO: We need to know if/when our client dies so we can get the buffer back! (blocked b/31632518)
Return<void> EvsDisplay::getTargetBuffer(getTargetBuffer_cb _hidl_cb) {
ALOGD("getTargetBuffer");
std::lock_guard<std::mutex> lock(mAccessLock);
if (mRequestedState == DisplayState::DEAD) {
ALOGE("Rejecting buffer request from object that lost ownership of the display.");
_hidl_cb({});
return {};
}
// If we don't already have a buffer, allocate one now
if (!mBuffer.memHandle) {
// Initialize our display window
// NOTE: This will cause the display to become "VISIBLE" before a frame is actually
// returned, which is contrary to the spec and will likely result in a black frame being
// (briefly) shown.
if (mGlWrapper->initialize(mDisplayProxy, mDisplayId)) {
// Assemble the buffer description we'll use for our render target
mBuffer.width = mGlWrapper->getWidth();
mBuffer.height = mGlWrapper->getHeight();
mBuffer.format = HAL_PIXEL_FORMAT_RGBA_8888;
mBuffer.usage = GRALLOC_USAGE_HW_RENDER | GRALLOC_USAGE_HW_COMPOSER;
mBuffer.bufferId = kDefaultDisplayBufferId;
mBuffer.pixelSize = 4;
} else {
// If we failed to initialize a EGL, then we're not going to display
// any.
mGlWrapper = nullptr;
}
// Allocate the buffer that will hold our displayable image
buffer_handle_t handle = nullptr;
GraphicBufferAllocator& alloc(GraphicBufferAllocator::get());
status_t result = alloc.allocate(mBuffer.width, mBuffer.height, mBuffer.format, 1,
mBuffer.usage, &handle, &mBuffer.stride, 0, "EvsDisplay");
if (result != NO_ERROR || !handle) {
ALOGE("Error %d allocating %d x %d graphics buffer", result, mBuffer.width,
mBuffer.height);
if (mGlWrapper) {
mGlWrapper->shutdown();
}
_hidl_cb({});
return {};
}
mBuffer.memHandle = handle;
mFrameBusy = false;
ALOGD("Allocated new buffer %p with stride %u", mBuffer.memHandle.getNativeHandle(),
mBuffer.stride);
}
// Do we have a frame available?
if (mFrameBusy) {
// This means either we have a 2nd client trying to compete for buffers
// (an unsupported mode of operation) or else the client hasn't returned
// a previously issued buffer yet (they're behaving badly).
// NOTE: We have to make the callback even if we have nothing to provide
ALOGE("getTargetBuffer called while no buffers available.");
_hidl_cb({});
return {};
} else {
// Mark our buffer as busy
mFrameBusy = true;
// Send the buffer to the client
ALOGD("Providing display buffer handle %p as id %d", mBuffer.memHandle.getNativeHandle(),
mBuffer.bufferId);
_hidl_cb(mBuffer);
return {};
}
}
/**
* This call tells the display that the buffer is ready for display.
* The buffer is no longer valid for use by the client after this call.
*/
Return<EvsResult> EvsDisplay::returnTargetBufferForDisplayImpl(const uint32_t bufferId,
const buffer_handle_t memHandle) {
ALOGD("returnTargetBufferForDisplay %p", memHandle);
std::lock_guard<std::mutex> lock(mAccessLock);
// Nobody should call us with a null handle
if (!memHandle) {
ALOGE("returnTargetBufferForDisplay called without a valid buffer handle.\n");
return EvsResult::INVALID_ARG;
}
if (bufferId != mBuffer.bufferId) {
ALOGE("Got an unrecognized frame returned.\n");
return EvsResult::INVALID_ARG;
}
if (!mFrameBusy) {
ALOGE("A frame was returned with no outstanding frames.\n");
return EvsResult::BUFFER_NOT_AVAILABLE;
}
mFrameBusy = false;
// If we've been displaced by another owner of the display, then we can't do anything else
if (mRequestedState == DisplayState::DEAD) {
return EvsResult::OWNERSHIP_LOST;
}
// If we were waiting for a new frame, this is it!
if (mRequestedState == DisplayState::VISIBLE_ON_NEXT_FRAME) {
mRequestedState = DisplayState::VISIBLE;
if (mGlWrapper) {
mGlWrapper->showWindow(mDisplayProxy, mDisplayId);
}
}
// Validate we're in an expected state
if (mRequestedState != DisplayState::VISIBLE) {
// We shouldn't get frames back when we're not visible.
ALOGE("Got an unexpected frame returned while not visible - ignoring.\n");
} else if (mGlWrapper) {
// This is where the buffer would be made visible.
if (!mGlWrapper->updateImageTexture(mBuffer)) {
return EvsResult::UNDERLYING_SERVICE_ERROR;
}
// Put the image on the screen
mGlWrapper->renderImageToScreen();
} else {
// TODO: Move below validation logic to somewhere else
#if 0
// For now we simply validate it has the data we expect in it by reading it back
// Lock our display buffer for reading
uint32_t* pixels = nullptr;
GraphicBufferMapper& mapper = GraphicBufferMapper::get();
mapper.lock(mBuffer.memHandle, GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_NEVER,
android::Rect(mBuffer.width, mBuffer.height), (void**)&pixels);
// If we failed to lock the pixel buffer, we're about to crash, but log it first
if (!pixels) {
ALOGE("Display failed to gain access to image buffer for reading");
}
// Check the test pixels
bool frameLooksGood = true;
for (unsigned row = 0; row < mBuffer.height; row++) {
for (unsigned col = 0; col < mBuffer.width; col++) {
// Index into the row to check the pixel at this column.
// We expect 0xFF in the LSB channel, a vertical gradient in the
// second channel, a horitzontal gradient in the third channel, and
// 0xFF in the MSB.
// The exception is the very first 32 bits which is used for the
// time varying frame signature to avoid getting fooled by a static image.
uint32_t expectedPixel = 0xFF0000FF | // MSB and LSB
((row & 0xFF) << 8) | // vertical gradient
((col & 0xFF) << 16); // horizontal gradient
if ((row | col) == 0) {
// we'll check the "uniqueness" of the frame signature below
continue;
}
// Walk across this row (we'll step rows below)
uint32_t receivedPixel = pixels[col];
if (receivedPixel != expectedPixel) {
ALOGE("Pixel check mismatch in frame buffer");
frameLooksGood = false;
break;
}
}
if (!frameLooksGood) {
break;
}
// Point to the next row (NOTE: gralloc reports stride in units of pixels)
pixels = pixels + mBuffer.stride;
}
// Ensure we don't see the same buffer twice without it being rewritten
static uint32_t prevSignature = ~0;
uint32_t signature = pixels[0] & 0xFF;
if (prevSignature == signature) {
frameLooksGood = false;
ALOGE("Duplicate, likely stale frame buffer detected");
}
// Release our output buffer
mapper.unlock(mBuffer.memHandle);
if (!frameLooksGood) {
return EvsResult::UNDERLYING_SERVICE_ERROR;
}
#endif
}
return EvsResult::OK;
}
Return<EvsResult> EvsDisplay::returnTargetBufferForDisplay(const V1_0::BufferDesc& buffer) {
return returnTargetBufferForDisplayImpl(buffer.bufferId, buffer.memHandle);
}
Return<void> EvsDisplay::getDisplayInfo_1_1(getDisplayInfo_1_1_cb _info_cb) {
if (mDisplayProxy != nullptr) {
return mDisplayProxy->getDisplayInfo(mDisplayId, _info_cb);
} else {
HwDisplayConfig nullConfig;
HwDisplayState nullState;
_info_cb(nullConfig, nullState);
return {};
}
}
} // namespace android::hardware::automotive::evs::V1_1::implementation
|