summaryrefslogtreecommitdiff
path: root/security/keymint/support/remote_prov_utils.cpp
diff options
context:
space:
mode:
authorDavid Drysdale <drysdale@google.com>2022-03-10 10:43:25 +0000
committerDavid Drysdale <drysdale@google.com>2022-03-10 10:54:37 +0000
commit08696a75435a4eb5ea826bf92ecd2a59e9f07e7a (patch)
treebbdd8407d277eb7b1d55046b982bafd246bc1715 /security/keymint/support/remote_prov_utils.cpp
parentcbc6a3305ea12a2afe30e30469693fe24067e86f (diff)
Prevent test crashes if device sets invalid curve
Test: VtsHalRemotelyProvisionedComponentTargetTest Change-Id: Ib623b3dcdd5a496b34314c1e0d1a310c8beeb18d
Diffstat (limited to 'security/keymint/support/remote_prov_utils.cpp')
-rw-r--r--security/keymint/support/remote_prov_utils.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/security/keymint/support/remote_prov_utils.cpp b/security/keymint/support/remote_prov_utils.cpp
index 0776282b27..5ff33db87e 100644
--- a/security/keymint/support/remote_prov_utils.cpp
+++ b/security/keymint/support/remote_prov_utils.cpp
@@ -225,7 +225,7 @@ ErrMsgOr<EekChain> generateEekChain(int32_t supportedEekCurve, size_t length,
bytevec prev_priv_key;
for (size_t i = 0; i < length - 1; ++i) {
auto keyPair = generateKeyPair(supportedEekCurve, false);
- if (!keyPair) keyPair.moveMessage();
+ if (!keyPair) return keyPair.moveMessage();
auto [pub_key, priv_key] = keyPair.moveValue();
// The first signing key is self-signed.
@@ -242,7 +242,7 @@ ErrMsgOr<EekChain> generateEekChain(int32_t supportedEekCurve, size_t length,
prev_priv_key = priv_key;
}
auto keyPair = generateKeyPair(supportedEekCurve, true);
- if (!keyPair) keyPair.moveMessage();
+ if (!keyPair) return keyPair.moveMessage();
auto [pub_key, priv_key] = keyPair.moveValue();
auto coseKey = constructCoseKey(supportedEekCurve, eekId, pub_key);