diff options
author | Xusong Wang <xusongw@google.com> | 2022-01-21 10:15:19 -0800 |
---|---|---|
committer | Xusong Wang <xusongw@google.com> | 2022-02-07 14:02:41 -0800 |
commit | 8805b2d67cdbd0cea31d5aba11069f7eaec59052 (patch) | |
tree | bc80961e06fdddd0758a8a5d6699ff6bd7b73453 /neuralnetworks/aidl/utils/src/Device.cpp | |
parent | e4061de77e99a1979e9e53bd81ac7f79e2e4f664 (diff) |
Address ANAPIC review comments -- hal.
- Document that IPreparedModel::execute*WithConfig are for single-time
usages, and IPreparedModel::createReusableExecution is for reusable
usages.
- Make PrepareModelConfig::cacheToken a fixed sized array.
Fixes: 215566186
Test: VtsHalNeuralnetworksTargetTest
Test: NNT_static
Change-Id: I9c5a49c46a3eac2828b9eb666f3d742038493121
Diffstat (limited to 'neuralnetworks/aidl/utils/src/Device.cpp')
-rw-r--r-- | neuralnetworks/aidl/utils/src/Device.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/neuralnetworks/aidl/utils/src/Device.cpp b/neuralnetworks/aidl/utils/src/Device.cpp index f3f4fdbba1..b64a40dcaa 100644 --- a/neuralnetworks/aidl/utils/src/Device.cpp +++ b/neuralnetworks/aidl/utils/src/Device.cpp @@ -229,7 +229,6 @@ nn::GeneralResult<nn::SharedPreparedModel> Device::prepareModel( const auto aidlDeadline = NN_TRY(convert(deadline)); auto aidlModelCache = NN_TRY(convert(modelCache)); auto aidlDataCache = NN_TRY(convert(dataCache)); - const auto aidlToken = NN_TRY(convert(token)); const auto cb = ndk::SharedRefBase::make<PreparedModelCallback>(kFeatureLevel); const auto scoped = kDeathHandler.protectCallback(cb.get()); @@ -240,12 +239,13 @@ nn::GeneralResult<nn::SharedPreparedModel> Device::prepareModel( const auto ret = kDevice->prepareModelWithConfig( aidlModel, {aidlPreference, aidlPriority, aidlDeadline, std::move(aidlModelCache), - std::move(aidlDataCache), aidlToken, std::move(aidlHints), + std::move(aidlDataCache), token, std::move(aidlHints), std::move(aidlExtensionPrefix)}, cb); HANDLE_ASTATUS(ret) << "prepareModel failed"; return cb->get(); } + const auto aidlToken = NN_TRY(convert(token)); const auto ret = kDevice->prepareModel(aidlModel, aidlPreference, aidlPriority, aidlDeadline, aidlModelCache, aidlDataCache, aidlToken, cb); HANDLE_ASTATUS(ret) << "prepareModel failed"; |