diff options
| author | Iris Chang <iris.chang@mediatek.com> | 2017-09-14 15:23:18 +0800 |
|---|---|---|
| committer | Keun Soo Yim <yim@google.com> | 2018-01-23 22:30:41 +0000 |
| commit | af5fad4036bdd1febc19a40a79b93d3fa06a22ac (patch) | |
| tree | 1640f26d228bc5db6fb79a14fb3e18e94670c898 /identity/support/src/cppbor_parse.cpp | |
| parent | 68d4dd6e85e257fce2120bcf13d83597baf8f052 (diff) | |
VTS: fix VtsHalKeymasterV3_0Target issue
Failed cases:
AttestationTest.RsaAttestation
AttestationTest.EcAttestation
Analysis:
The verify_attestation_record() in Keymaster_hidl_hal_test.cpp calls
parse_attestation_record() to set the value of att_challenge. It fails
to compare att_challenge with challenge by memcmp.
Because setToExternal() method uses buffer pointer to local variable
(record), not use memcpy to copy into itself buffer in
parse_attestation_record(). When it leaves the parse_attestation_record(),
we will get the att_challenge which is null buffer to compare with challenge
incorrectly.
Fix: use memcpy to copy the buffer.
Bug: 65039571
Test: build passed. VtsHalKeymasterV3_0Target -> PASSED: 106, FAILED: 0.
Change-Id: I700a9242cc9a5f4cb196b62860823601e4088531
Merged-In: I700a9242cc9a5f4cb196b62860823601e4088531
(cherry picked from 54ca32a130a0450b444848046199d62876b55301)
(cherry picked from commit 926a8e7440a0c85d39dbf7143bfe03964363ddec)
Diffstat (limited to 'identity/support/src/cppbor_parse.cpp')
0 files changed, 0 insertions, 0 deletions