summaryrefslogtreecommitdiff
path: root/identity/support/src/cppbor_parse.cpp
diff options
context:
space:
mode:
authorDavid Gross <dgross@google.com>2019-09-09 14:32:09 -0700
committerDavid Gross <dgross@google.com>2019-09-12 14:27:35 -0700
commit29d90d1455eb5aa94764a0eeb9e1395d6aec2e61 (patch)
tree472c2d36eae5968c12db2787abc0593445c597a7 /identity/support/src/cppbor_parse.cpp
parent71cb010ba3e44189e5a5a887e1b756df5bdc1df0 (diff)
"successful preparation means successful execution" guarantee neglects bad operation inputs
Under certain circumstances, we guarantee that a prepared model can be executed successfully. In describing those circumstances, we neglected to specify that operation input operands must have legal values for the guarantee to hold. For example, the guarantee doesn't hold if an ADD operation has an activation input that is not one of the defined values; or if a RESHAPE operation has a shape input in which two or more components are -1. This change modifies the guarantee to apply only when operation input operands have legal values. It also documents this guarantee for burst execution. Note that if an operation has an input operand that can be proven to have an illegal value at preparation time (e.g., a constant value that is illegal), model preparation might (but is not required to) fail for that reason. Bug: 135933040 Test: $ cd neuralnetworks ; mma Change-Id: I8b421550dd89e4bbbdae899e7cb5e9e88a46d2fb (cherry picked from commit 48544cc38a6499553672ca940fd6899af3d264b2)
Diffstat (limited to 'identity/support/src/cppbor_parse.cpp')
0 files changed, 0 insertions, 0 deletions