summaryrefslogtreecommitdiff
path: root/identity/support/src/cppbor_parse.cpp
diff options
context:
space:
mode:
authorYtai Ben-Tsvi <ytai@google.com>2019-09-09 11:50:45 -0700
committerYtai Ben-Tsvi <ytai@google.com>2019-09-13 10:31:52 -0700
commit11107873aa5fecc0a76cbea97c10766bf80ad6f4 (patch)
tree73fe8a00445db10acd8e7ed4ee5028fc92ec2a59 /identity/support/src/cppbor_parse.cpp
parent629fde972ace6be538faf78701a7c459f0b666d4 (diff)
Improve visibility of IMemory security risks
This change renames the IMemory raw pointer accessors to unsecure*() to make it apparent to coders and code reviewers that the returned buffer may potentially be shared with untrusted processes, who may, after the fact, attempt to read and/or modify the contents. This may lead to hard to find security bugs and hopefully the rename makes it harder to forget. The change also attempts to fix all the callsites to make everything build correctly, but in the processes, wherever the callsite code was not obviously secure, I added a TODO requesting the owners to either document why it's secure or to change the code. Apologies in advance to the owners if there are some false positives here - I don't have enough context to reason about all the different callsites. Test: Completely syntactic change. Made sure code still builds. Change-Id: Icfde96b17f8c763dcf304456c224127310c1c289
Diffstat (limited to 'identity/support/src/cppbor_parse.cpp')
0 files changed, 0 insertions, 0 deletions