diff options
| author | Eino-Ville Talvala <etalvala@google.com> | 2017-05-08 15:29:28 -0700 |
|---|---|---|
| committer | Eino-Ville Talvala <etalvala@google.com> | 2017-05-08 15:29:28 -0700 |
| commit | e0a0a1c2391bbf97cd1c2cb39f82a16a11b70d16 (patch) | |
| tree | 02472fd7f6a1178e3ab4e05fb6c1568fbe766495 /camera/device/1.0/default/CameraDevice.cpp | |
| parent | 79c636a4ff19cb9b369f7695bdbc72129b3ceeab (diff) | |
Camera: Clean up TODOs that aren't going to be addressed.
These TODOs aren't in scope for the wrapper libraries.
Leave the few TODOs that have bugs tracking them, and the ones that
are from autogenerated metadata.
Test: Builds
Bug: 34108979
Change-Id: Ib28467a4fbcfaab4a0809334bc62eabb9290797a
Diffstat (limited to 'camera/device/1.0/default/CameraDevice.cpp')
| -rw-r--r-- | camera/device/1.0/default/CameraDevice.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/camera/device/1.0/default/CameraDevice.cpp b/camera/device/1.0/default/CameraDevice.cpp index 4f26c54812..6f4e70f834 100644 --- a/camera/device/1.0/default/CameraDevice.cpp +++ b/camera/device/1.0/default/CameraDevice.cpp @@ -183,7 +183,6 @@ int CameraDevice::sDequeueBuffer(struct preview_stream_ops* w, } int CameraDevice::sLockBuffer(struct preview_stream_ops*, buffer_handle_t*) { - // TODO: make sure lock_buffer is indeed a no-op (and will always be) return 0; } @@ -585,8 +584,6 @@ Return<void> CameraDevice::getCameraInfo(getCameraInfo_cb _hidl_cb) { cameraInfo.facing = (CameraFacing) info.facing; // Device 1.0 does not support external camera facing. // The closest approximation would be front camera. - // TODO: figure out should we override here or let - // camera service handle it. if (cameraInfo.facing == CameraFacing::EXTERNAL) { cameraInfo.facing = CameraFacing::FRONT; } |