summaryrefslogtreecommitdiff
path: root/audio/effect/all-versions/default/Conversions.cpp
diff options
context:
space:
mode:
authorMikhail Naganov <mnaganov@google.com>2018-12-11 16:36:53 -0800
committerMikhail Naganov <mnaganov@google.com>2018-12-11 16:54:29 -0800
commit543bf9cb161e173bed2a733c2ce442cea90bacd8 (patch)
tree72f130c23da38e645f763d5f7448e71aa4c676b9 /audio/effect/all-versions/default/Conversions.cpp
parent315002043adfb811bbe65934052c3be5b7ebd123 (diff)
Audio HAL: Simplify types updates for 'common' and 'audio' packages
Instead of importing every single type individually ("using <type>"), import entire namespaces of ::android::hardware::audio::CPP_VERSION and ::android::hardware::audio::common::CPP_VERSION inside the "implementation" namespace in the default implementation. This simplifies modifying types, as it is not needed anymore to surround "using <type>" directives with #if MAJOR_VERSION ... Note that the contents of the namespaces are imported inside the "implementation" namespace, which reduces risks of name collision Also, fixed the namespace for HidlUtils--it needs to be in 'implementation'. Test: make Change-Id: I81bbb3074b5763717ae72e747a075fd46dc36d18
Diffstat (limited to 'audio/effect/all-versions/default/Conversions.cpp')
-rw-r--r--audio/effect/all-versions/default/Conversions.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/audio/effect/all-versions/default/Conversions.cpp b/audio/effect/all-versions/default/Conversions.cpp
index 50b0562502..b1c0b0dc13 100644
--- a/audio/effect/all-versions/default/Conversions.cpp
+++ b/audio/effect/all-versions/default/Conversions.cpp
@@ -17,14 +17,11 @@
#include "Conversions.h"
#include "HidlUtils.h"
-using ::android::hardware::audio::common::CPP_VERSION::HidlUtils;
-
#include <memory.h>
#include <stdio.h>
#include <common/all-versions/VersionUtils.h>
-using ::android::hardware::audio::common::CPP_VERSION::HidlUtils;
using ::android::hardware::audio::common::utils::EnumBitfield;
namespace android {
@@ -34,6 +31,8 @@ namespace effect {
namespace CPP_VERSION {
namespace implementation {
+using ::android::hardware::audio::common::CPP_VERSION::implementation::HidlUtils;
+
void effectDescriptorFromHal(const effect_descriptor_t& halDescriptor,
EffectDescriptor* descriptor) {
HidlUtils::uuidFromHal(halDescriptor.type, &descriptor->type);