summaryrefslogtreecommitdiff
path: root/audio/common/all-versions/default/tests/hidlutils_tests.cpp
diff options
context:
space:
mode:
authorMikhail Naganov <mnaganov@google.com>2021-02-19 14:08:52 -0800
committerMikhail Naganov <mnaganov@google.com>2021-02-19 14:21:17 -0800
commit178317b2525ce150215a89e21b7d88013ee35a1d (patch)
treeed4bc468ee0d4c2abcfe74dca02cda319ed50b68 /audio/common/all-versions/default/tests/hidlutils_tests.cpp
parentc3325707a552b8b13a044fed1b5de2888f28f7cd (diff)
audio: Put stronger rules on vendor extension enums
The namespace part has been made mandatory. The namespace must be at least 3 characters. Bug: 176144684 Test: atest android.hardware.audio.common@7.0-util_tests Test: atest android.hardware.audio@7.0-util_tests Test: atest android.hardware.audio.effect@7.0-util_tests Change-Id: If8578dfab80b51d9c30042e99bfbf70f40598afa
Diffstat (limited to 'audio/common/all-versions/default/tests/hidlutils_tests.cpp')
-rw-r--r--audio/common/all-versions/default/tests/hidlutils_tests.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/audio/common/all-versions/default/tests/hidlutils_tests.cpp b/audio/common/all-versions/default/tests/hidlutils_tests.cpp
index ec6bdf38ef..e154453e2b 100644
--- a/audio/common/all-versions/default/tests/hidlutils_tests.cpp
+++ b/audio/common/all-versions/default/tests/hidlutils_tests.cpp
@@ -432,10 +432,16 @@ TEST(HidlUtils, ConvertDeviceType) {
// The enums module is too small to have unit tests on its own.
TEST(HidlUtils, VendorExtension) {
EXPECT_TRUE(xsd::isVendorExtension("VX_GOOGLE_VR_42"));
+ EXPECT_TRUE(xsd::isVendorExtension("VX_QCM_SPK"));
EXPECT_FALSE(xsd::isVendorExtension(""));
EXPECT_FALSE(xsd::isVendorExtension("random string"));
EXPECT_FALSE(xsd::isVendorExtension("VX_"));
+ EXPECT_FALSE(xsd::isVendorExtension("VX_X"));
+ EXPECT_FALSE(xsd::isVendorExtension("VX_X_"));
+ EXPECT_FALSE(xsd::isVendorExtension("VX_X_X"));
+ EXPECT_FALSE(xsd::isVendorExtension("VX_XX_X"));
EXPECT_FALSE(xsd::isVendorExtension("VX_GOOGLE_$$"));
+ EXPECT_FALSE(xsd::isVendorExtension("VX_$CM_SPK"));
}
TEST(HidlUtils, ConvertInvalidDeviceAddress) {