summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChih-Hung Hsieh <chh@google.com>2017-11-20 10:49:11 -0800
committerChih-Hung Hsieh <chh@google.com>2017-11-20 10:49:11 -0800
commit3f2ea62d06e5a119dc82b412a2b13f74f0477dba (patch)
tree3d2b24748328c58e4525631c4453d4c037fd568a
parentae6b2a5f1ec56c4d68aac10062ccb74e4df730ac (diff)
Use -Werror in hardware/interfaces
* Use hidl_defaults, which has -Wall -Werror. Bug: 66996870 Test: build with WITH_TIDY=1 Change-Id: Ifbca0e176a8e031acc27256eb46d23b89cdf1a0e
-rw-r--r--bluetooth/1.0/default/Android.bp1
-rw-r--r--boot/1.0/default/Android.bp2
-rw-r--r--gatekeeper/1.0/default/Android.bp2
-rw-r--r--gnss/1.0/default/Android.bp4
-rw-r--r--soundtrigger/2.0/default/Android.mk2
-rw-r--r--thermal/1.0/default/Android.bp1
-rw-r--r--tv/cec/1.0/default/Android.bp2
-rw-r--r--tv/input/1.0/default/Android.bp2
8 files changed, 14 insertions, 2 deletions
diff --git a/bluetooth/1.0/default/Android.bp b/bluetooth/1.0/default/Android.bp
index 63e75629b6..48bbadf8a7 100644
--- a/bluetooth/1.0/default/Android.bp
+++ b/bluetooth/1.0/default/Android.bp
@@ -115,6 +115,7 @@ cc_test_host {
cc_binary {
name: "android.hardware.bluetooth@1.0-service",
+ defaults: ["hidl_defaults"],
relative_install_path: "hw",
vendor: true,
init_rc: ["android.hardware.bluetooth@1.0-service.rc"],
diff --git a/boot/1.0/default/Android.bp b/boot/1.0/default/Android.bp
index c9b74925ee..6cfbf32eeb 100644
--- a/boot/1.0/default/Android.bp
+++ b/boot/1.0/default/Android.bp
@@ -1,5 +1,6 @@
cc_library_shared {
name: "android.hardware.boot@1.0-impl",
+ defaults: ["hidl_defaults"],
relative_install_path: "hw",
vendor: true,
srcs: ["BootControl.cpp"],
@@ -17,6 +18,7 @@ cc_library_shared {
cc_binary {
name: "android.hardware.boot@1.0-service",
+ defaults: ["hidl_defaults"],
relative_install_path: "hw",
vendor: true,
init_rc: ["android.hardware.boot@1.0-service.rc"],
diff --git a/gatekeeper/1.0/default/Android.bp b/gatekeeper/1.0/default/Android.bp
index 4e6c9f04a3..ae3b91cd03 100644
--- a/gatekeeper/1.0/default/Android.bp
+++ b/gatekeeper/1.0/default/Android.bp
@@ -1,5 +1,6 @@
cc_library_shared {
name: "android.hardware.gatekeeper@1.0-impl",
+ defaults: ["hidl_defaults"],
relative_install_path: "hw",
vendor: true,
@@ -18,6 +19,7 @@ cc_library_shared {
cc_binary {
name: "android.hardware.gatekeeper@1.0-service",
+ defaults: ["hidl_defaults"],
relative_install_path: "hw",
vendor: true,
init_rc: ["android.hardware.gatekeeper@1.0-service.rc"],
diff --git a/gnss/1.0/default/Android.bp b/gnss/1.0/default/Android.bp
index 007ed975ac..ca495e6959 100644
--- a/gnss/1.0/default/Android.bp
+++ b/gnss/1.0/default/Android.bp
@@ -1,5 +1,6 @@
cc_library_shared {
name: "android.hardware.gnss@1.0-impl",
+ defaults: ["hidl_defaults"],
vendor: true,
relative_install_path: "hw",
srcs: [
@@ -27,14 +28,13 @@ cc_library_shared {
"libhardware",
],
- cflags: ["-Werror"],
-
}
cc_binary {
relative_install_path: "hw",
vendor: true,
name: "android.hardware.gnss@1.0-service",
+ defaults: ["hidl_defaults"],
init_rc: ["android.hardware.gnss@1.0-service.rc"],
srcs: ["service.cpp"],
diff --git a/soundtrigger/2.0/default/Android.mk b/soundtrigger/2.0/default/Android.mk
index 068c6b4bbd..926285862f 100644
--- a/soundtrigger/2.0/default/Android.mk
+++ b/soundtrigger/2.0/default/Android.mk
@@ -23,6 +23,8 @@ LOCAL_MODULE_RELATIVE_PATH := hw
LOCAL_SRC_FILES := \
SoundTriggerHalImpl.cpp
+LOCAL_CFLAGS := -Wall -Werror
+
LOCAL_SHARED_LIBRARIES := \
libhidlbase \
libhidltransport \
diff --git a/thermal/1.0/default/Android.bp b/thermal/1.0/default/Android.bp
index 2054b88f70..9d81474b70 100644
--- a/thermal/1.0/default/Android.bp
+++ b/thermal/1.0/default/Android.bp
@@ -34,6 +34,7 @@ cc_library_shared {
cc_binary {
name: "android.hardware.thermal@1.0-service",
+ defaults: ["hidl_defaults"],
relative_install_path: "hw",
vendor: true,
init_rc: ["android.hardware.thermal@1.0-service.rc"],
diff --git a/tv/cec/1.0/default/Android.bp b/tv/cec/1.0/default/Android.bp
index efb88ec559..069f327389 100644
--- a/tv/cec/1.0/default/Android.bp
+++ b/tv/cec/1.0/default/Android.bp
@@ -1,5 +1,6 @@
cc_library_shared {
name: "android.hardware.tv.cec@1.0-impl",
+ defaults: ["hidl_defaults"],
vendor: true,
relative_install_path: "hw",
srcs: ["HdmiCec.cpp"],
@@ -18,6 +19,7 @@ cc_library_shared {
cc_binary {
name: "android.hardware.tv.cec@1.0-service",
+ defaults: ["hidl_defaults"],
relative_install_path: "hw",
vendor: true,
init_rc: ["android.hardware.tv.cec@1.0-service.rc"],
diff --git a/tv/input/1.0/default/Android.bp b/tv/input/1.0/default/Android.bp
index f8956f18ff..7c140a5c41 100644
--- a/tv/input/1.0/default/Android.bp
+++ b/tv/input/1.0/default/Android.bp
@@ -1,5 +1,6 @@
cc_library_shared {
name: "android.hardware.tv.input@1.0-impl",
+ defaults: ["hidl_defaults"],
vendor: true,
relative_install_path: "hw",
srcs: ["TvInput.cpp"],
@@ -19,6 +20,7 @@ cc_library_shared {
cc_binary {
name: "android.hardware.tv.input@1.0-service",
+ defaults: ["hidl_defaults"],
relative_install_path: "hw",
vendor: true,
init_rc: ["android.hardware.tv.input@1.0-service.rc"],