diff options
| author | Ady Abraham <adyabr@google.com> | 2022-02-18 17:13:53 -0800 |
|---|---|---|
| committer | Ady Abraham <adyabr@google.com> | 2022-02-22 02:54:41 +0000 |
| commit | def47ca32f7e932b27e6be5fd1b75e336b890856 (patch) | |
| tree | 7bd37dd8a9d960f549f5632eb905b4fbc48bfdf0 /hwc3 | |
| parent | ab41f421c73e1eb42f7185a1a2fdbed7ff0253fe (diff) | |
hwc3: remove IComposer.dumpDebugInfo
aidl already have a dump funciton, so there is no need to
expose a custom dumpDebugInfo from IComposer.
Bug: 220171623
Test: atest VtsHalGraphicsComposer3_TargetTest
Test: adb shell dumpsys SurfaceFlinger
Test: adb shell dumpsys android.hardware.graphics.composer3.IComposer/default
Change-Id: Ifaf91e74b01230c5926fc43619cada80deaa1630
Diffstat (limited to 'hwc3')
| -rw-r--r-- | hwc3/Composer.cpp | 8 | ||||
| -rw-r--r-- | hwc3/Composer.h | 3 |
2 files changed, 7 insertions, 4 deletions
diff --git a/hwc3/Composer.cpp b/hwc3/Composer.cpp index afd2602..4a57d96 100644 --- a/hwc3/Composer.cpp +++ b/hwc3/Composer.cpp @@ -48,9 +48,11 @@ ndk::ScopedAStatus Composer::createClient(std::shared_ptr<IComposerClient>* outC return ndk::ScopedAStatus::ok(); } -ndk::ScopedAStatus Composer::dumpDebugInfo(std::string* output) { - mHal->dumpDebugInfo(output); - return ndk::ScopedAStatus::ok(); +binder_status_t Composer::dump(int fd, const char** /*args*/, uint32_t /*numArgs*/) { + std::string output; + mHal->dumpDebugInfo(&output); + write(fd, output.c_str(), output.size()); + return STATUS_OK; } ndk::ScopedAStatus Composer::getCapabilities(std::vector<Capability>* caps) { diff --git a/hwc3/Composer.h b/hwc3/Composer.h index 218465c..9324c0b 100644 --- a/hwc3/Composer.h +++ b/hwc3/Composer.h @@ -28,9 +28,10 @@ class Composer : public BnComposer { public: Composer(std::unique_ptr<IComposerHal> hal) : mHal(std::move(hal)) {} + binder_status_t dump(int fd, const char** args, uint32_t numArgs) override; + // compser3 api ndk::ScopedAStatus createClient(std::shared_ptr<IComposerClient>* client) override; - ndk::ScopedAStatus dumpDebugInfo(std::string* output) override; ndk::ScopedAStatus getCapabilities(std::vector<Capability>* caps) override; protected: |