diff options
| author | Oleg Matcovschi <omatcovschi@google.com> | 2023-05-23 11:21:10 -0700 |
|---|---|---|
| committer | Oleg Matcovschi <omatcovschi@google.com> | 2023-05-26 05:55:00 +0000 |
| commit | 8c9370f42fc9414b9e1307140e3a0cce16d03c5c (patch) | |
| tree | ac705dbf8ae81c2fda326f3dd93886dc6e057b9b | |
| parent | 2a4e22ebcc9afeabdd953b5eb3f9b12e33433838 (diff) | |
libhwc2.1: histogram: pass parameters as references
Bug: 277948998
Bug: 261376040
Change-Id: I7021e0445e4b938b98eaa7dab54d5622ada2957b
Merged-In: I7021e0445e4b938b98eaa7dab54d5622ada2957b
Signed-off-by: Oleg Matcovschi <omatcovschi@google.com>
| -rw-r--r-- | libhwc2.1/histogram_mediator.cpp | 4 | ||||
| -rw-r--r-- | libhwc2.1/histogram_mediator.h | 6 | ||||
| -rw-r--r-- | libhwc2.1/pixel-display.cpp | 2 | ||||
| -rw-r--r-- | libhwc2.1/pixel-display.h | 2 |
4 files changed, 7 insertions, 7 deletions
diff --git a/libhwc2.1/histogram_mediator.cpp b/libhwc2.1/histogram_mediator.cpp index 991b972..a09f579 100644 --- a/libhwc2.1/histogram_mediator.cpp +++ b/libhwc2.1/histogram_mediator.cpp @@ -93,7 +93,7 @@ int histogram::HistogramMediator::calculateThreshold(const RoiRect &roi) { } histogram::HistogramErrorCode histogram::HistogramMediator::setRoiWeightThreshold( - const RoiRect roi, const Weight weight, const HistogramPos pos) { + const RoiRect &roi, const Weight &weight, const HistogramPos &pos) { int threshold = calculateThreshold(roi); mIDLHistogram->setHistogramROI((uint16_t)roi.left, (uint16_t)roi.top, (uint16_t)(roi.right - roi.left), @@ -118,7 +118,7 @@ histogram::HistogramErrorCode histogram::HistogramMediator::collectRoiLuma( return histogram::HistogramErrorCode::NONE; } -histogram::RoiRect histogram::HistogramMediator::calRoi(RoiRect roi) { +histogram::RoiRect histogram::HistogramMediator::calRoi(const RoiRect &roi) { RoiRect roi_return = {-1, -1, -1, -1}; ExynosDisplayDrmInterface *moduleDisplayInterface = static_cast<ExynosDisplayDrmInterface *>(mDisplay->mDisplayInterface.get()); diff --git a/libhwc2.1/histogram_mediator.h b/libhwc2.1/histogram_mediator.h index eac4c98..fa81e0b 100644 --- a/libhwc2.1/histogram_mediator.h +++ b/libhwc2.1/histogram_mediator.h @@ -62,9 +62,9 @@ public: HistogramErrorCode requestHist(); HistogramErrorCode cancelHistRequest(); HistogramErrorCode collectRoiLuma(std::vector<char16_t> *buf); - HistogramErrorCode setRoiWeightThreshold(const RoiRect roi, const Weight weight, - const HistogramPos pos); - RoiRect calRoi(RoiRect roi); + HistogramErrorCode setRoiWeightThreshold(const RoiRect &roi, const Weight &weight, + const HistogramPos &pos); + RoiRect calRoi(const RoiRect &roi); struct HistogramReceiver : public IDLHistogram { HistogramReceiver() : mHistData(){}; void callbackHistogram(char16_t *bin) override; diff --git a/libhwc2.1/pixel-display.cpp b/libhwc2.1/pixel-display.cpp index cfb57a0..fec7309 100644 --- a/libhwc2.1/pixel-display.cpp +++ b/libhwc2.1/pixel-display.cpp @@ -199,7 +199,7 @@ ndk::ScopedAStatus Display::setRefreshRateThrottle(int delayMs, int *_aidl_retur return ndk::ScopedAStatus::fromExceptionCode(EX_UNSUPPORTED_OPERATION); } -bool Display::runMediator(const RoiRect roi, const Weight weight, const HistogramPos pos, +bool Display::runMediator(const RoiRect &roi, const Weight &weight, const HistogramPos &pos, std::vector<char16_t> *histogrambuffer) { if (mMediator.setRoiWeightThreshold(roi, weight, pos) != HistogramErrorCode::NONE) { ALOGE("histogram error, SET_ROI_WEIGHT_THRESHOLD ERROR\n"); diff --git a/libhwc2.1/pixel-display.h b/libhwc2.1/pixel-display.h index 2202a68..df437af 100644 --- a/libhwc2.1/pixel-display.h +++ b/libhwc2.1/pixel-display.h @@ -66,7 +66,7 @@ public: ndk::ScopedAStatus isOperationRateSupported(bool *_aidl_return) override; private: - bool runMediator(const RoiRect roi, const Weight weight, const HistogramPos pos, + bool runMediator(const RoiRect &roi, const Weight &weight, const HistogramPos &pos, std::vector<char16_t> *histogrambuffer); ExynosDisplay *mDisplay = nullptr; histogram::HistogramMediator mMediator; |