diff options
| author | Mathias Agopian <mathias@google.com> | 2013-06-05 14:30:54 -0700 |
|---|---|---|
| committer | Jean-Baptiste Queru <jbq@google.com> | 2013-08-05 14:28:46 -0700 |
| commit | e5886d917807d56fed07cd8e88b9be268d70368e (patch) | |
| tree | c2aa83402c83a5711d486bbc6f3564c2be6c3fa6 /opengl/tests/gl_basic/gl_basic.cpp | |
| parent | 9f476fd08079701d1ad0f7c591667b6e673ed38e (diff) | |
fix a possible deadlock when removing a layer and destroying a client
generally the last reference to a Layer is released in commitTransaction()
with mStateLock held. Layer itself only holds weak references to Client,
however, ~Layer() briefly promotes this weak reference -- during that time
the all other strong references to that Client go away, ~Layer is left with
the last one... then hell breaks loose as ~Client is called, which in turn
needs to acquire mStateLock.
We fix this by holding a temporary copy of the drawing state during
the transaction so that the side-effects of copying the current
state into the drawing state are seen only after mStateLock has
been released.
Bug: 9106453
Change-Id: Ic5348ac12283500ead87286a37565e8da35f1db2
Diffstat (limited to 'opengl/tests/gl_basic/gl_basic.cpp')
0 files changed, 0 insertions, 0 deletions