diff options
author | Siarhei Vishniakou <svv@google.com> | 2018-01-04 11:46:44 -0800 |
---|---|---|
committer | Siarhei Vishniakou <svv@google.com> | 2018-01-04 12:17:15 -0800 |
commit | 587c3f048427550df64d87817548f3987fe52d78 (patch) | |
tree | 575c883b95c67231ae09d60672b07d52b3787d9d /opengl/tests/gl_basic/gl_basic.cpp | |
parent | b28c6742fa7ce8ff69eebf6b15140730066135d3 (diff) |
Return std::string to not point to freed memory
Since the code was changed to use std::string instead of String8, it is
no longer safe to pass a raw pointer to internal memory of the string
object, since std::string creates a copy even if the data itself is not
being modified.
Instead, return std::string to the calling function and let the function
access the pointer when necessary.
Bug: 71541263
Test: boot up asan build on pixel 2 xl, then interact with google
calendar and chrome. Observe no crashes with the patch.
Change-Id: I50311085b50eab73e71409f6446213d2ff04bc47
Diffstat (limited to 'opengl/tests/gl_basic/gl_basic.cpp')
0 files changed, 0 insertions, 0 deletions