diff options
| author | Garfield Tan <xutan@google.com> | 2021-07-19 12:02:16 -0700 |
|---|---|---|
| committer | Alec Mouri <alecmouri@google.com> | 2022-01-12 18:02:41 +0000 |
| commit | 2914a57d755051a3e5f05154d784a08019500946 (patch) | |
| tree | 130fe57fec85684b25283cb69ef4aa6f4186376c /opengl/tests/gl_basic/gl_basic.cpp | |
| parent | 41a8b01966f7400046252733b140cebb45466faf (diff) | |
Skip creating external textures that exceeds size limit
Skia always accept an Android buffer and wraps it around with a texture
even if its size exceeds the limit GL exposes. Therefore let's skip
creating the texture in SurfaceFlinger and outputs an error log to
logcat.
I chose to do it in SurfaceFlinger rather than RenderEngine is because
the external texture mapping is designed to be asynchronous, so it'd be
better to keep that way. The limit is also exposed out of RenderEngine
so SurfaceFlinger can check it before creating external textures as
well.
Bug: 190399306
Bug: 204316511
Test: The test mentioned in the bug fails instead of crashing
SurfaceFlinger.
Test: atest SurfaceFlinger_test
Test: atest libsurfaceflinger_unittest
Change-Id: I52d253ed5a10f0e4ade372048721913405ed668a
(cherry picked from commit 9c9c19134593655c36fe70aaa45a91ad4f75e36f)
Merged-In: I52d253ed5a10f0e4ade372048721913405ed668a
Diffstat (limited to 'opengl/tests/gl_basic/gl_basic.cpp')
0 files changed, 0 insertions, 0 deletions