diff options
| author | Vishnu Nair <vishnun@google.com> | 2021-08-30 15:31:08 -0700 |
|---|---|---|
| committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2021-09-20 22:31:47 +0000 |
| commit | 000089527fde072acbf17d1c2ee333e4ca595315 (patch) | |
| tree | 1bca85935788654055cf665af42a53634cef23bf /opengl/tests/gl_basic/gl_basic.cpp | |
| parent | 47b3ffac2014319c42eded655faa23e4c0714f94 (diff) | |
Surface: Release references to BlastBufferQueue and SurfaceControl on Surface#destroy
SurfaceView clients may hold on to surface references. In S this means
they would extend the lifetime of the SurfaceControl resulting in
"leaking" buffers until the references are cleared or the app is
terminated.
Fix this by calling a new destroy function on Surface which will
explicitly remove references to the SurfaceControl and BBQ it holds.
This is safe because SurfaceView controls the lifecycle of the Surface
and knows when the Surface will become invalid. Once invalid, the Surface
cannot become valid again.
Test: repro steps in bug
Bug: 198133921
Change-Id: I88fe98fa275dd76e20a5403c24bd2cb3bee5346d
Merged-In: I88fe98fa275dd76e20a5403c24bd2cb3bee5346d
(cherry picked from commit fe4d05cd44be3ee805c14c49e59b88d8cf67c4a1)
Diffstat (limited to 'opengl/tests/gl_basic/gl_basic.cpp')
0 files changed, 0 insertions, 0 deletions