diff options
| author | chaviw <chaviw@google.com> | 2021-04-29 09:15:20 -0500 |
|---|---|---|
| committer | chaviw <chaviw@google.com> | 2021-05-10 12:48:18 -0500 |
| commit | 1f5e7403885f02b61d0763a38c0511f0787b8a0c (patch) | |
| tree | 9c7945ede3f9253ac3d3810797f79ff2f7299dbb | |
| parent | 06784f2b9f5c6c6274b2a2a82b413f3d460e3257 (diff) | |
Mark ASurfaceControl.setGeometry as deprecated.
With the introduction of setCrop, setPosition, setBufferTransform, and
setScale, there's no need for setGeometry. The setGeometry API is
confusing since it's handled in buffer space where all other APIs are
handled in layer space.
Test: N/A
Bug: 185533162
Change-Id: Ief07dbf77f34e942d97ee5b0293b0a038bc1435b
| -rw-r--r-- | include/android/surface_control.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/include/android/surface_control.h b/include/android/surface_control.h index 988137112b..351e6faf24 100644 --- a/include/android/surface_control.h +++ b/include/android/surface_control.h @@ -358,6 +358,11 @@ void ASurfaceTransaction_setColor(ASurfaceTransaction* transaction, * enum. * * Available since API level 29. + * + * @deprecated Use setCrop, setPosition, setBufferTransform, and setScale instead. Those functions + * provide well defined behavior and allows for more control by the apps. It also allows the caller + * to set different properties at different times, instead of having to specify all the desired + * properties at once. */ void ASurfaceTransaction_setGeometry(ASurfaceTransaction* transaction, ASurfaceControl* surface_control, const ARect& source, |