diff options
Diffstat (limited to 'tools/aapt2/java')
-rw-r--r-- | tools/aapt2/java/AnnotationProcessor.cpp | 4 | ||||
-rw-r--r-- | tools/aapt2/java/AnnotationProcessor.h | 6 | ||||
-rw-r--r-- | tools/aapt2/java/ClassDefinition.cpp | 6 | ||||
-rw-r--r-- | tools/aapt2/java/ClassDefinition.h | 35 | ||||
-rw-r--r-- | tools/aapt2/java/JavaClassGenerator.cpp | 6 | ||||
-rw-r--r-- | tools/aapt2/java/JavaClassGenerator.h | 19 | ||||
-rw-r--r-- | tools/aapt2/java/JavaClassGenerator_test.cpp | 2 | ||||
-rw-r--r-- | tools/aapt2/java/ManifestClassGenerator.cpp | 2 |
8 files changed, 42 insertions, 38 deletions
diff --git a/tools/aapt2/java/AnnotationProcessor.cpp b/tools/aapt2/java/AnnotationProcessor.cpp index 2951e5cff6d7..a0ef00b1ea1f 100644 --- a/tools/aapt2/java/AnnotationProcessor.cpp +++ b/tools/aapt2/java/AnnotationProcessor.cpp @@ -20,6 +20,8 @@ #include "util/Util.h" +using android::StringPiece; + namespace aapt { void AnnotationProcessor::AppendCommentLine(std::string& comment) { @@ -54,7 +56,7 @@ void AnnotationProcessor::AppendComment(const StringPiece& comment) { for (StringPiece line : util::Tokenize(comment, '\n')) { line = util::TrimWhitespace(line); if (!line.empty()) { - std::string lineCopy = line.ToString(); + std::string lineCopy = line.to_string(); AppendCommentLine(lineCopy); } } diff --git a/tools/aapt2/java/AnnotationProcessor.h b/tools/aapt2/java/AnnotationProcessor.h index 666a7f356768..99cd44fd2cc1 100644 --- a/tools/aapt2/java/AnnotationProcessor.h +++ b/tools/aapt2/java/AnnotationProcessor.h @@ -20,7 +20,7 @@ #include <sstream> #include <string> -#include "util/StringPiece.h" +#include "androidfw/StringPiece.h" namespace aapt { @@ -58,7 +58,7 @@ class AnnotationProcessor { * configurations, * we need to collect all the comments. */ - void AppendComment(const StringPiece& comment); + void AppendComment(const android::StringPiece& comment); void AppendNewLine(); @@ -66,7 +66,7 @@ class AnnotationProcessor { * Writes the comments and annotations to the stream, with the given prefix * before each line. */ - void WriteToStream(std::ostream* out, const StringPiece& prefix) const; + void WriteToStream(std::ostream* out, const android::StringPiece& prefix) const; private: enum : uint32_t { diff --git a/tools/aapt2/java/ClassDefinition.cpp b/tools/aapt2/java/ClassDefinition.cpp index f1f1f925480c..53d6ea1a79c5 100644 --- a/tools/aapt2/java/ClassDefinition.cpp +++ b/tools/aapt2/java/ClassDefinition.cpp @@ -16,7 +16,9 @@ #include "java/ClassDefinition.h" -#include "util/StringPiece.h" +#include "androidfw/StringPiece.h" + +using android::StringPiece; namespace aapt { @@ -43,7 +45,7 @@ void ClassDefinition::WriteToStream(const StringPiece& prefix, bool final, } *out << "final class " << name_ << " {\n"; - std::string new_prefix = prefix.ToString(); + std::string new_prefix = prefix.to_string(); new_prefix.append(kIndent); for (const std::unique_ptr<ClassMember>& member : members_) { diff --git a/tools/aapt2/java/ClassDefinition.h b/tools/aapt2/java/ClassDefinition.h index d8b61d919fd8..64e4b2987be3 100644 --- a/tools/aapt2/java/ClassDefinition.h +++ b/tools/aapt2/java/ClassDefinition.h @@ -21,10 +21,10 @@ #include <string> #include "android-base/macros.h" +#include "androidfw/StringPiece.h" #include "Resource.h" #include "java/AnnotationProcessor.h" -#include "util/StringPiece.h" #include "util/Util.h" namespace aapt { @@ -41,7 +41,7 @@ class ClassMember { virtual bool empty() const = 0; - virtual void WriteToStream(const StringPiece& prefix, bool final, + virtual void WriteToStream(const android::StringPiece& prefix, bool final, std::ostream* out) const { processor_.WriteToStream(out, prefix); } @@ -53,12 +53,12 @@ class ClassMember { template <typename T> class PrimitiveMember : public ClassMember { public: - PrimitiveMember(const StringPiece& name, const T& val) - : name_(name.ToString()), val_(val) {} + PrimitiveMember(const android::StringPiece& name, const T& val) + : name_(name.to_string()), val_(val) {} bool empty() const override { return false; } - void WriteToStream(const StringPiece& prefix, bool final, + void WriteToStream(const android::StringPiece& prefix, bool final, std::ostream* out) const override { ClassMember::WriteToStream(prefix, final, out); @@ -79,12 +79,12 @@ class PrimitiveMember : public ClassMember { template <> class PrimitiveMember<std::string> : public ClassMember { public: - PrimitiveMember(const StringPiece& name, const std::string& val) - : name_(name.ToString()), val_(val) {} + PrimitiveMember(const android::StringPiece& name, const std::string& val) + : name_(name.to_string()), val_(val) {} bool empty() const override { return false; } - void WriteToStream(const StringPiece& prefix, bool final, + void WriteToStream(const android::StringPiece& prefix, bool final, std::ostream* out) const override { ClassMember::WriteToStream(prefix, final, out); @@ -106,14 +106,13 @@ using StringMember = PrimitiveMember<std::string>; template <typename T> class PrimitiveArrayMember : public ClassMember { public: - explicit PrimitiveArrayMember(const StringPiece& name) - : name_(name.ToString()) {} + explicit PrimitiveArrayMember(const android::StringPiece& name) : name_(name.to_string()) {} void AddElement(const T& val) { elements_.push_back(val); } bool empty() const override { return false; } - void WriteToStream(const StringPiece& prefix, bool final, + void WriteToStream(const android::StringPiece& prefix, bool final, std::ostream* out) const override { ClassMember::WriteToStream(prefix, final, out); @@ -147,22 +146,18 @@ enum class ClassQualifier { None, Static }; class ClassDefinition : public ClassMember { public: - static bool WriteJavaFile(const ClassDefinition* def, - const StringPiece& package, bool final, - std::ostream* out); + static bool WriteJavaFile(const ClassDefinition* def, const android::StringPiece& package, + bool final, std::ostream* out); - ClassDefinition(const StringPiece& name, ClassQualifier qualifier, - bool createIfEmpty) - : name_(name.ToString()), - qualifier_(qualifier), - create_if_empty_(createIfEmpty) {} + ClassDefinition(const android::StringPiece& name, ClassQualifier qualifier, bool createIfEmpty) + : name_(name.to_string()), qualifier_(qualifier), create_if_empty_(createIfEmpty) {} void AddMember(std::unique_ptr<ClassMember> member) { members_.push_back(std::move(member)); } bool empty() const override; - void WriteToStream(const StringPiece& prefix, bool final, + void WriteToStream(const android::StringPiece& prefix, bool final, std::ostream* out) const override; private: diff --git a/tools/aapt2/java/JavaClassGenerator.cpp b/tools/aapt2/java/JavaClassGenerator.cpp index 6e7c707847b9..b71dc485633b 100644 --- a/tools/aapt2/java/JavaClassGenerator.cpp +++ b/tools/aapt2/java/JavaClassGenerator.cpp @@ -23,6 +23,7 @@ #include <tuple> #include "android-base/logging.h" +#include "androidfw/StringPiece.h" #include "NameMangler.h" #include "Resource.h" @@ -32,7 +33,8 @@ #include "java/AnnotationProcessor.h" #include "java/ClassDefinition.h" #include "process/SymbolTable.h" -#include "util/StringPiece.h" + +using android::StringPiece; namespace aapt { @@ -58,7 +60,7 @@ static bool IsValidSymbol(const StringPiece& symbol) { * Replace those with '_'. */ static std::string Transform(const StringPiece& symbol) { - std::string output = symbol.ToString(); + std::string output = symbol.to_string(); for (char& c : output) { if (c == '.' || c == '-') { c = '_'; diff --git a/tools/aapt2/java/JavaClassGenerator.h b/tools/aapt2/java/JavaClassGenerator.h index 190e73b66b9e..5cf556ea5707 100644 --- a/tools/aapt2/java/JavaClassGenerator.h +++ b/tools/aapt2/java/JavaClassGenerator.h @@ -20,10 +20,11 @@ #include <ostream> #include <string> +#include "androidfw/StringPiece.h" + #include "ResourceTable.h" #include "ResourceValues.h" #include "process/IResourceTableConsumer.h" -#include "util/StringPiece.h" namespace aapt { @@ -69,22 +70,20 @@ class JavaClassGenerator { * We need to generate these symbols in a separate file. * Returns true on success. */ - bool Generate(const StringPiece& packageNameToGenerate, std::ostream* out); + bool Generate(const android::StringPiece& packageNameToGenerate, std::ostream* out); - bool Generate(const StringPiece& packageNameToGenerate, - const StringPiece& outputPackageName, std::ostream* out); + bool Generate(const android::StringPiece& packageNameToGenerate, + const android::StringPiece& outputPackageName, std::ostream* out); const std::string& getError() const; private: - bool AddMembersToTypeClass(const StringPiece& packageNameToGenerate, - const ResourceTablePackage* package, - const ResourceTableType* type, + bool AddMembersToTypeClass(const android::StringPiece& packageNameToGenerate, + const ResourceTablePackage* package, const ResourceTableType* type, ClassDefinition* outTypeClassDef); - void AddMembersToStyleableClass(const StringPiece& packageNameToGenerate, - const std::string& entryName, - const Styleable* styleable, + void AddMembersToStyleableClass(const android::StringPiece& packageNameToGenerate, + const std::string& entryName, const Styleable* styleable, ClassDefinition* outStyleableClassDef); bool SkipSymbol(SymbolState state); diff --git a/tools/aapt2/java/JavaClassGenerator_test.cpp b/tools/aapt2/java/JavaClassGenerator_test.cpp index 3d3d24e6aab5..55c5cb26892f 100644 --- a/tools/aapt2/java/JavaClassGenerator_test.cpp +++ b/tools/aapt2/java/JavaClassGenerator_test.cpp @@ -22,6 +22,8 @@ #include "test/Test.h" #include "util/Util.h" +using android::StringPiece; + namespace aapt { TEST(JavaClassGeneratorTest, FailWhenEntryIsJavaKeyword) { diff --git a/tools/aapt2/java/ManifestClassGenerator.cpp b/tools/aapt2/java/ManifestClassGenerator.cpp index db84f295db2a..de8e59aed6da 100644 --- a/tools/aapt2/java/ManifestClassGenerator.cpp +++ b/tools/aapt2/java/ManifestClassGenerator.cpp @@ -24,6 +24,8 @@ #include "util/Maybe.h" #include "xml/XmlDom.h" +using android::StringPiece; + namespace aapt { static Maybe<StringPiece> ExtractJavaIdentifier(IDiagnostics* diag, |