diff options
author | Muhammad Qureshi <muhammadq@google.com> | 2020-04-15 17:13:12 -0700 |
---|---|---|
committer | Muhammad Qureshi <muhammadq@google.com> | 2020-04-17 10:10:17 -0700 |
commit | cdf291d297198f7a6ca09f35127d19bec5e298e3 (patch) | |
tree | a45587728b20d1ec76e39031bc29fc27f835de82 /tools | |
parent | 2b80990bbcadd557b0c4cfe45d410d2aaeae3dee (diff) |
Remove kMaxPushedAtomId from atoms_info.
Hardcode kMaxPushedAtomId in StatsdStats.
Bug: 154164020
Test: bit statsd_test:*
Change-Id: Ibca731d9783686a9e3caf0ad580e1d62038d68e2
Diffstat (limited to 'tools')
-rw-r--r-- | tools/stats_log_api_gen/Collation.cpp | 7 | ||||
-rw-r--r-- | tools/stats_log_api_gen/Collation.h | 1 | ||||
-rw-r--r-- | tools/stats_log_api_gen/atoms_info_writer.cpp | 7 | ||||
-rw-r--r-- | tools/stats_log_api_gen/atoms_info_writer.h | 2 | ||||
-rw-r--r-- | tools/stats_log_api_gen/main.cpp | 2 |
5 files changed, 5 insertions, 14 deletions
diff --git a/tools/stats_log_api_gen/Collation.cpp b/tools/stats_log_api_gen/Collation.cpp index 526876f5ec26..958e94efcf9c 100644 --- a/tools/stats_log_api_gen/Collation.cpp +++ b/tools/stats_log_api_gen/Collation.cpp @@ -478,7 +478,6 @@ static void populateFieldNumberToAtomDeclSet(const shared_ptr<AtomDecl>& atomDec int collate_atoms(const Descriptor* descriptor, const string& moduleName, Atoms* atoms) { int errorCount = 0; - int maxPushedAtomId = 2; for (int i = 0; i < descriptor->field_count(); i++) { const FieldDescriptor* atomField = descriptor->field(i); @@ -563,14 +562,8 @@ int collate_atoms(const Descriptor* descriptor, const string& moduleName, Atoms* atoms->non_chained_decls.insert(nonChainedAtomDecl); } - - if (atomDecl->code < PULL_ATOM_START_ID && atomDecl->code > maxPushedAtomId) { - maxPushedAtomId = atomDecl->code; - } } - atoms->maxPushedAtomId = maxPushedAtomId; - if (dbg) { printf("signatures = [\n"); for (SignatureInfoMap::const_iterator it = atoms->signatureInfoMap.begin(); diff --git a/tools/stats_log_api_gen/Collation.h b/tools/stats_log_api_gen/Collation.h index b513463ec98f..043f8b1e74d8 100644 --- a/tools/stats_log_api_gen/Collation.h +++ b/tools/stats_log_api_gen/Collation.h @@ -191,7 +191,6 @@ struct Atoms { AtomDeclSet decls; AtomDeclSet non_chained_decls; SignatureInfoMap nonChainedSignatureInfoMap; - int maxPushedAtomId; }; /** diff --git a/tools/stats_log_api_gen/atoms_info_writer.cpp b/tools/stats_log_api_gen/atoms_info_writer.cpp index b33995017bae..58a91e43dcd1 100644 --- a/tools/stats_log_api_gen/atoms_info_writer.cpp +++ b/tools/stats_log_api_gen/atoms_info_writer.cpp @@ -25,12 +25,11 @@ namespace android { namespace stats_log_api_gen { -static void write_atoms_info_header_body(FILE* out, const Atoms& atoms) { +static void write_atoms_info_header_body(FILE* out) { fprintf(out, "struct AtomsInfo {\n"); fprintf(out, " const static std::set<int> kAtomsWithAttributionChain;\n"); fprintf(out, " const static std::set<int> kWhitelistedAtoms;\n"); fprintf(out, "};\n"); - fprintf(out, "const static int kMaxPushedAtomId = %d;\n\n", atoms.maxPushedAtomId); } static void write_atoms_info_cpp_body(FILE* out, const Atoms& atoms) { @@ -65,7 +64,7 @@ static void write_atoms_info_cpp_body(FILE* out, const Atoms& atoms) { } -int write_atoms_info_header(FILE* out, const Atoms& atoms, const string& namespaceStr) { +int write_atoms_info_header(FILE* out, const string& namespaceStr) { // Print prelude fprintf(out, "// This file is autogenerated\n"); fprintf(out, "\n"); @@ -78,7 +77,7 @@ int write_atoms_info_header(FILE* out, const Atoms& atoms, const string& namespa write_namespace(out, namespaceStr); - write_atoms_info_header_body(out, atoms); + write_atoms_info_header_body(out); fprintf(out, "\n"); write_closing_namespace(out, namespaceStr); diff --git a/tools/stats_log_api_gen/atoms_info_writer.h b/tools/stats_log_api_gen/atoms_info_writer.h index ffe9e439d7ff..09a4303eaee6 100644 --- a/tools/stats_log_api_gen/atoms_info_writer.h +++ b/tools/stats_log_api_gen/atoms_info_writer.h @@ -29,7 +29,7 @@ using namespace std; int write_atoms_info_cpp(FILE* out, const Atoms& atoms, const string& namespaceStr, const string& importHeader); -int write_atoms_info_header(FILE* out, const Atoms& atoms, const string& namespaceStr); +int write_atoms_info_header(FILE* out, const string& namespaceStr); } // namespace stats_log_api_gen } // namespace android diff --git a/tools/stats_log_api_gen/main.cpp b/tools/stats_log_api_gen/main.cpp index fda57369d7bf..136933b8cfb2 100644 --- a/tools/stats_log_api_gen/main.cpp +++ b/tools/stats_log_api_gen/main.cpp @@ -229,7 +229,7 @@ static int run(int argc, char const* const* argv) { fprintf(stderr, "Unable to open file for write: %s\n", atomsInfoHeaderFilename.c_str()); return 1; } - errorCount = android::stats_log_api_gen::write_atoms_info_header(out, atoms, cppNamespace); + errorCount = android::stats_log_api_gen::write_atoms_info_header(out, cppNamespace); fclose(out); } |