diff options
| author | Anton Hansson <hansson@google.com> | 2018-11-23 15:21:20 +0000 |
|---|---|---|
| committer | Anton Hansson <hansson@google.com> | 2018-11-23 15:25:52 +0000 |
| commit | 2f5dd12af0c78ba077a9dc2b9cf77b772b618cd1 (patch) | |
| tree | 8e3bfa22f96a7d8ed6a72a5f293e8c167f1a089a /tools/stringslint/stringslint.py | |
| parent | abbcfb2dba6517d19455ce565a782977b827b11f (diff) | |
Add linter for strings attribute names
Only one bad example for now, which is a misspelling that's not
entirely uncommon and can lead to real problems (see linked bug).
Example output:
Line 58: 'my_new': Misspelled <string> attribute.
Actual: translateable
Example: translatable
Bug: 119884572
Test: with a misspelled attribute
Change-Id: If61412fe318a34191920781c4834584363080e11
Diffstat (limited to 'tools/stringslint/stringslint.py')
| -rw-r--r-- | tools/stringslint/stringslint.py | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tools/stringslint/stringslint.py b/tools/stringslint/stringslint.py index 03c0b9af66a0..afe91cda37b0 100644 --- a/tools/stringslint/stringslint.py +++ b/tools/stringslint/stringslint.py @@ -145,6 +145,13 @@ def lint(path): if "translatable" in child.attrib and child.attrib["translatable"].lower() == "false": continue + misspelled_attributes = [ + ("translateable", "translatable"), + ] + for misspelling, expected in misspelled_attributes: + if misspelling in child.attrib: + error(child, "Misspelled <string> attribute.", misspelling, expected) + limit = re.search("CHAR[ _-]LIMIT=(\d+|NONE|none)", comment.text) if limit is None: info(child, "Missing CHAR LIMIT to aid translation", |