diff options
author | Artur Satayev <satayev@google.com> | 2020-01-20 17:35:58 +0000 |
---|---|---|
committer | Artur Satayev <satayev@google.com> | 2020-01-29 19:54:58 +0000 |
commit | 9430c17a6c86b228e2e6d3f2a19171eb3cec745d (patch) | |
tree | aab27b2b365ac91b03f408e6cf448626759bc49d /tools/hiddenapi/merge_csv.py | |
parent | cd70c935b3df02709e1fdae7b4716057ba65131d (diff) |
Use py3 features in merge_csv.py.
- Use csv.QUOTE_MINIMAL strategy to only quote fields with special characters.
- Open file as 'r', not 'rb'.
- Use 'unix' dialect for '\n' as line terminator, instead of \r\n.
Bug: 145132366
Test: diff -w out/soong/hiddenapi/hiddenapi-greylist.csv
Change-Id: I888f3219beee5b83e53f05589a90a05f93399fe3
Diffstat (limited to 'tools/hiddenapi/merge_csv.py')
-rwxr-xr-x | tools/hiddenapi/merge_csv.py | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/tools/hiddenapi/merge_csv.py b/tools/hiddenapi/merge_csv.py index 48c07553ffef..96619273af8d 100755 --- a/tools/hiddenapi/merge_csv.py +++ b/tools/hiddenapi/merge_csv.py @@ -21,20 +21,19 @@ import csv import sys csv_readers = [ - csv.DictReader(open(csv_file, 'rb'), delimiter=',', quotechar='|') + csv.DictReader(open(csv_file, 'r'), delimiter=',', quotechar='|') for csv_file in sys.argv[1:] ] # Build union of all columns from source files: headers = set() for reader in csv_readers: - headers = headers.union(reader.fieldnames) + headers = headers.union(reader.fieldnames) # Concatenate all files to output: -out = csv.DictWriter(sys.stdout, delimiter=',', quotechar='|', fieldnames = sorted(headers)) +out = csv.DictWriter(sys.stdout, delimiter=',', quotechar='|', quoting=csv.QUOTE_MINIMAL, + dialect='unix', fieldnames=sorted(headers)) out.writeheader() for reader in csv_readers: - for row in reader: - out.writerow(row) - - + for row in reader: + out.writerow(row) |