summaryrefslogtreecommitdiff
path: root/tools/codegen
diff options
context:
space:
mode:
authorEugene Susla <eugenesusla@google.com>2020-11-03 18:24:06 -0800
committerEugene Susla <eugenesusla@google.com>2020-11-04 12:40:58 -0800
commitddb26814559a0c1e01593f29b180b501ea48e5f6 (patch)
treee8892bbb16293d1d67f21d7c931f38a291b7775c /tools/codegen
parent6ef0203cd46024a12e5ab8c83861396fbc35ad08 (diff)
Disregard annotation params for stale dataclass detection
Annotation processor seens annotation args with constants already inlined, making it challenging to compare to the souce-generated metadata that contains initial expressions. For now just ignoring args for all non-DataClass annotations to prevent false positives Test: . frameworks/base/tests/Codegen/runTest.sh Exempt-From-Owner-Approval: changing metadata on multiple files Change-Id: I640816ae0f20f36b1b828bc2161f53788c4a4dae
Diffstat (limited to 'tools/codegen')
-rw-r--r--tools/codegen/src/com/android/codegen/InputSignaturesComputation.kt1
-rw-r--r--tools/codegen/src/com/android/codegen/SharedConstants.kt2
2 files changed, 2 insertions, 1 deletions
diff --git a/tools/codegen/src/com/android/codegen/InputSignaturesComputation.kt b/tools/codegen/src/com/android/codegen/InputSignaturesComputation.kt
index 1aea57514855..83108e5ae109 100644
--- a/tools/codegen/src/com/android/codegen/InputSignaturesComputation.kt
+++ b/tools/codegen/src/com/android/codegen/InputSignaturesComputation.kt
@@ -63,6 +63,7 @@ private fun ClassPrinter.annotationToString(ann: AnnotationExpr?): String {
append("@")
append(getFullClassName(ann.nameAsString))
if (ann is MarkerAnnotationExpr) return@buildString
+ if (!ann.nameAsString.startsWith("DataClass")) return@buildString
append("(")
diff --git a/tools/codegen/src/com/android/codegen/SharedConstants.kt b/tools/codegen/src/com/android/codegen/SharedConstants.kt
index 147f18c35e5c..2e176c3d3bec 100644
--- a/tools/codegen/src/com/android/codegen/SharedConstants.kt
+++ b/tools/codegen/src/com/android/codegen/SharedConstants.kt
@@ -1,7 +1,7 @@
package com.android.codegen
const val CODEGEN_NAME = "codegen"
-const val CODEGEN_VERSION = "1.0.19"
+const val CODEGEN_VERSION = "1.0.20"
const val CANONICAL_BUILDER_CLASS = "Builder"
const val BASE_BUILDER_CLASS = "BaseBuilder"