diff options
| author | Christopher Wiley <wiley@google.com> | 2015-08-24 15:06:58 -0700 |
|---|---|---|
| committer | Christopher Wiley <wiley@google.com> | 2015-08-31 13:55:46 -0700 |
| commit | 5b88363ed30c9501e0bfa6de5a216e0ea24317b9 (patch) | |
| tree | 7ab5fe162e01cf4c0b1acb834f127cb16f16d401 /tools/aidl | |
| parent | 60dd5d5966ebe993f5a81c46d9dea62c207abfd3 (diff) | |
Tighten up compiler flags for aidl
Turn all warnings to errors, with special cases for places where
yacc forces us to be lenient. Remove one variable with 0 references
elsewhere in the code.
These flags are confined to be clang only because the Windows SDK build
is using an older compiler that does not understand these flags.
Change-Id: I6407bd331c25b8845bde46e9a917bce1d6857bd8
Diffstat (limited to 'tools/aidl')
| -rw-r--r-- | tools/aidl/Android.mk | 12 | ||||
| -rw-r--r-- | tools/aidl/aidl.cpp | 5 |
2 files changed, 11 insertions, 6 deletions
diff --git a/tools/aidl/Android.mk b/tools/aidl/Android.mk index cb94a3626270..6866c6c9a55a 100644 --- a/tools/aidl/Android.mk +++ b/tools/aidl/Android.mk @@ -8,6 +8,17 @@ ifeq ($(TARGET_BUILD_APPS)$(filter true,$(TARGET_BUILD_PDK)),) LOCAL_PATH:= $(call my-dir) include $(CLEAR_VARS) +LOCAL_CLANG_CFLAGS := -Wall -Werror +# Tragically, the code is riddled with unused parameters. +LOCAL_CLANG_CFLAGS += -Wno-unused-parameter +# yacc dumps a lot of code *just in case*. +LOCAL_CLANG_CFLAGS += -Wno-unused-function +LOCAL_CLANG_CFLAGS += -Wno-unneeded-internal-declaration +# yacc is a tool from a more civilized age. +LOCAL_CLANG_CFLAGS += -Wno-deprecated-register +# yacc also has a habit of using char* over const char*. +LOCAL_CLANG_CFLAGS += -Wno-writable-strings + LOCAL_SRC_FILES := \ AST.cpp \ Type.cpp \ @@ -22,7 +33,6 @@ LOCAL_SRC_FILES := \ options.cpp \ search_path.cpp \ -LOCAL_CFLAGS := -g LOCAL_MODULE := aidl LOCAL_MODULE_HOST_OS := darwin linux windows diff --git a/tools/aidl/aidl.cpp b/tools/aidl/aidl.cpp index a3cd12657f9a..d77f2b13dd97 100644 --- a/tools/aidl/aidl.cpp +++ b/tools/aidl/aidl.cpp @@ -165,11 +165,6 @@ import_import_parsed(buffer_type* statement) { } -static ParserCallbacks g_importCallbacks = { - &main_document_parsed, - &import_import_parsed -}; - // ========================================================== static int check_filename(const char* filename, const char* package, buffer_type* name) |