summaryrefslogtreecommitdiff
path: root/tools/aapt2
diff options
context:
space:
mode:
authorChih-Hung Hsieh <chh@google.com>2020-02-11 14:27:11 -0800
committerChih-Hung Hsieh <chh@google.com>2020-02-11 14:27:11 -0800
commitf2ef6579f2fe70ddca7fa3d443b3780d0264eb88 (patch)
tree831808e5fd62fe0f303c25fd3e509951cce0f2e8 /tools/aapt2
parent668daf03416525dbcd96f2a06b2fd5dccb7cec13 (diff)
Fix clang-tidy performance-faster-string-find warnings
Bug: 30411878 Test: build with WITH_TIDY=1 Change-Id: I7fd815aa401fbcaff97b772f3ba5d6f1d2034011
Diffstat (limited to 'tools/aapt2')
-rw-r--r--tools/aapt2/dump/DumpManifest.cpp4
-rw-r--r--tools/aapt2/java/ManifestClassGenerator.cpp2
2 files changed, 3 insertions, 3 deletions
diff --git a/tools/aapt2/dump/DumpManifest.cpp b/tools/aapt2/dump/DumpManifest.cpp
index 92f1ddb292e1..42a64716701d 100644
--- a/tools/aapt2/dump/DumpManifest.cpp
+++ b/tools/aapt2/dump/DumpManifest.cpp
@@ -1175,7 +1175,7 @@ class Activity : public ManifestExtractor::Element {
}
// Fully qualify the activity name
- ssize_t idx = name.find(".");
+ ssize_t idx = name.find('.');
if (idx == 0) {
name = package + name;
} else if (idx < 0) {
@@ -2125,7 +2125,7 @@ bool ManifestExtractor::Dump(text::Printer* printer, IDiagnostics* diag) {
size_t pos = file_path.find("lib/");
if (pos != std::string::npos) {
file_path = file_path.substr(pos + 4);
- pos = file_path.find("/");
+ pos = file_path.find('/');
if (pos != std::string::npos) {
file_path = file_path.substr(0, pos);
}
diff --git a/tools/aapt2/java/ManifestClassGenerator.cpp b/tools/aapt2/java/ManifestClassGenerator.cpp
index 10e504ec0752..09ea03b23c9a 100644
--- a/tools/aapt2/java/ManifestClassGenerator.cpp
+++ b/tools/aapt2/java/ManifestClassGenerator.cpp
@@ -39,7 +39,7 @@ static Maybe<std::string> ExtractJavaIdentifier(IDiagnostics* diag, const Source
}
// Normalize only the java identifier, leave the original value unchanged.
- if (result.find("-") != std::string::npos) {
+ if (result.find('-') != std::string::npos) {
result = JavaClassGenerator::TransformToFieldName(result);
}